Add BY15.json with domain owner and records#35905
Add BY15.json with domain owner and records#35905Sh0tgvn45off wants to merge 1 commit intois-a-dev:mainfrom
Conversation
Hi there! 👋You've successfully made a pull request! Here are some steps to do while waiting for a maintainer to review the pull request:
Note: Because of the influx of pull requests we are trying to do them all, but this would mean longer wait time. We'll try to get to them when we can. Thanks for the patience. |
| @@ -0,0 +1,8 @@ | |||
| { | |||
There was a problem hiding this comment.
CI will fail: tests/json.test.js enforces that domain JSON filenames are all-lowercase (see validateFileName, line ~99). Please rename domains/BY15.json to a lowercase filename (e.g. domains/by15.json).
| @@ -0,0 +1,8 @@ | |||
| { | |||
There was a problem hiding this comment.
The PR description requests www.lazarousmoyo.is-a.dev, but this file registers by15.is-a.dev (filename defines the subdomain). Please align the filename/subdomain with the requested domain (e.g. lazarousmoyo.json and/or www.lazarousmoyo.json depending on what you intend to register).
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "owner": { | |||
| "username": "Sh0tgvn45off" | |||
There was a problem hiding this comment.
The PR template requires contact info under the owner key, but this file only includes owner.username. Please add owner.email (or another contact method supported by the project’s domain structure) so maintainers can reach you if needed.
| "username": "Sh0tgvn45off" | |
| "username": "Sh0tgvn45off", | |
| "email": "maintainer@example.com" |
Sh0tgvn45off
left a comment
There was a problem hiding this comment.
email set to moyolazarous45@gmail.com
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "owner": { | |||
| "username": "Sh0tgvn45off" | |||
|
due to high surge/influx of PRs, we will automatically close PRs that failed the CI test result, kindly check, read, follow and understand our curated guide -> https://docs.is-a.dev |
Requirements
ownerkey.Email: moyolazarous45@gmail.com
Website Preview
https://sh0tgvn45off.github.io/lazarousmoyo.me/ I want it to be www.lazarousmoyo.is-a.dev