Skip to content

Commit 3134be9

Browse files
committed
cleanup
1 parent c2fd455 commit 3134be9

3 files changed

Lines changed: 6 additions & 95 deletions

File tree

isaaclab_arena_curobo/curobo_ik_utils.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ def from_embodiment(cls, embodiment, **kwargs) -> StandaloneIKReachability:
222222

223223
return cls(get_curobo_cfg_for(embodiment), **kwargs)
224224

225-
def _to_curobo_device(self, tensor: torch.Tensor) -> torch.Tensor:
225+
def to_curobo_device(self, tensor: torch.Tensor) -> torch.Tensor:
226226
"""Move a tensor onto the cuRobo CUDA device / dtype (device isolation)."""
227227
return tensor.to(device=self.tensor_args.device, dtype=self.tensor_args.dtype)
228228

@@ -236,8 +236,8 @@ def _make_pose(
236236
"""Create a cuRobo ``Pose`` on the cuRobo device, converting xyzw->wxyz when needed."""
237237
from curobo.types.math import Pose
238238

239-
position = self._to_curobo_device(position)
240-
quaternion = self._to_curobo_device(quaternion)
239+
position = self.to_curobo_device(position)
240+
quaternion = self.to_curobo_device(quaternion)
241241
quaternion_wxyz = torch.roll(quaternion, shifts=1, dims=-1) if quat_is_xyzw else quaternion
242242
return Pose(position=position, quaternion=quaternion_wxyz)
243243

isaaclab_arena_curobo/tests/test_ik_gated_placement.py

Lines changed: 0 additions & 92 deletions
This file was deleted.

isaaclab_arena_curobo/tests/test_standalone_ik_layout_validator.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
from __future__ import annotations
1515

1616
import torch
17+
import pytest
1718
from unittest.mock import MagicMock
1819

1920

@@ -94,6 +95,7 @@ def _fake_embodiment():
9495
return embodiment
9596

9697

98+
@pytest.mark.curobo_deps
9799
def test_validator_accepts_when_all_grasps_feasible(monkeypatch):
98100
"""A layout is accepted (and stamped reachable) when every movable-object grasp is feasible."""
99101
from isaaclab_arena.relations.placement_validation import PlacementCheck
@@ -110,6 +112,7 @@ def test_validator_accepts_when_all_grasps_feasible(monkeypatch):
110112
assert captured["num_grasps"] == 1
111113

112114

115+
@pytest.mark.curobo_deps
113116
def test_validator_rejects_when_any_grasp_infeasible(monkeypatch):
114117
"""A layout is rejected (and stamped unreachable) when any movable-object grasp is infeasible."""
115118
from isaaclab_arena.relations.placement_validation import PlacementCheck

0 commit comments

Comments
 (0)