Skip to content

Commit 6f7b71b

Browse files
committed
add comments
1 parent b44699e commit 6f7b71b

2 files changed

Lines changed: 5 additions & 9 deletions

File tree

isaaclab_arena/relations/relations.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,11 @@ class NoCollision(Relation):
125125
unordered pair once.
126126
127127
Note: Loss computation is handled by NoCollisionLossStrategy in relation_loss_strategies.py.
128+
129+
NOTE: If both A.add_relation(NoCollision(B)) and B.add_relation(NoCollision(A)) are present,
130+
the solver will compute the loss twice and the relation graph becomes cyclic, which can cause
131+
issues during environment creation. Deduplication or cycle detection should be addressed at a
132+
higher level.
128133
"""
129134

130135
def __init__(

isaaclab_arena/tests/test_bounding_box.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,6 @@
99

1010
from isaaclab_arena.utils.bounding_box import AxisAlignedBoundingBox
1111

12-
# =============================================================================
13-
# Single-env tests (N=1, properties return (1, 3) or (1,) tensors)
14-
# =============================================================================
15-
1612

1713
def test_bounding_box_single_env_properties():
1814
"""Single env: properties return tensors with leading dim 1."""
@@ -67,11 +63,6 @@ def test_bounding_box_single_env_get_corners_at():
6763
torch.testing.assert_close(corners_offset[0, 0], corners[0, 0] + torch.tensor([10.0, 0.0, 0.0]))
6864

6965

70-
# =============================================================================
71-
# Multi-env batch tests (N>1, properties return (N, 3) or (N,) tensors)
72-
# =============================================================================
73-
74-
7566
def test_bounding_box_multi_env_properties():
7667
"""Multi-env: properties return (N, 3) or (N,) tensors."""
7768
aabb = AxisAlignedBoundingBox(

0 commit comments

Comments
 (0)