Open
Conversation
55b9269 to
02df632
Compare
f83ac21 to
f92ea6b
Compare
Signed-off-by: Clemens Volk <cvolk@nvidia.com>
Signed-off-by: Clemens Volk <cvolk@nvidia.com>
Signed-off-by: Clemens Volk <cvolk@nvidia.com>
Signed-off-by: Clemens Volk <cvolk@nvidia.com>
Signed-off-by: Clemens Volk <cvolk@nvidia.com>
… page Signed-off-by: Clemens Volk <cvolk@nvidia.com>
Replace AI-generated bullet lists and abstract stubs with a walkthrough of the two-phase recording system. Use the real ObjectMovedRateMetric implementation as the custom metric example. Signed-off-by: Clemens Volk <cvolk@nvidia.com>
Move concept_policy_design, concept_remote_policies_design, and policy_evaluation/evaluation_types into a new concepts/policy/ subdirectory. Remove the standalone Policy Evaluation section from the top-level navigation. Update all cross-references. Signed-off-by: Clemens Volk <cvolk@nvidia.com>
Signed-off-by: Clemens Volk <cvolk@nvidia.com>
Signed-off-by: Clemens Volk <cvolk@nvidia.com>
Signed-off-by: Clemens Volk <cvolk@nvidia.com>
Signed-off-by: Clemens Volk <cvolk@nvidia.com>
Signed-off-by: Clemens Volk <cvolk@nvidia.com>
Signed-off-by: Clemens Volk <cvolk@nvidia.com>
Signed-off-by: Clemens Volk <cvolk@nvidia.com>
Signed-off-by: Clemens Volk <cvolk@nvidia.com>
Signed-off-by: Clemens Volk <cvolk@nvidia.com>
Resolve conflict in docs/index.rst: keep Concepts toctree from branch, add new Arena in Your Repo section from main. Move Arena in Your Repo above Concepts in the navigation. Signed-off-by: Clemens Volk <cvolk@nvidia.com>
Signed-off-by: Clemens Volk <cvolk@nvidia.com>
cvolkcvolk
approved these changes
Apr 9, 2026
Co-authored-by: isaaclab-review-bot[bot] <270793704+isaaclab-review-bot[bot]@users.noreply.github.com>
Co-authored-by: isaaclab-review-bot[bot] <270793704+isaaclab-review-bot[bot]@users.noreply.github.com>
Co-authored-by: isaaclab-review-bot[bot] <270793704+isaaclab-review-bot[bot]@users.noreply.github.com>
Replace nonexistent how_open() with get_openness() to match the actual Openable affordance API. Signed-off-by: Clemens Volk <cvolk@nvidia.com>
Co-authored-by: isaaclab-review-bot[bot] <270793704+isaaclab-review-bot[bot]@users.noreply.github.com>
Co-authored-by: isaaclab-review-bot[bot] <270793704+isaaclab-review-bot[bot]@users.noreply.github.com>
kellyguo11
reviewed
Apr 10, 2026
kellyguo11
left a comment
There was a problem hiding this comment.
Nice work cleaning up the docs — the rewritten pages are a massive improvement over the old templated format. The restructuring into scene/, task/, embodiment/, and policy/ subdirectories makes the concept docs much more navigable.
A few things I spotted:
Reset submodules/IsaacLab back to the commit on main (e57379c6). It was inadvertently changed in b4311e5. Signed-off-by: Clemens Volk <cvolk@nvidia.com>
Superpowers plans and specs are now stored outside the repo, so the gitignore entry is no longer needed. Signed-off-by: Clemens Volk <cvolk@nvidia.com>
Signed-off-by: Clemens Volk <cvolk@nvidia.com>
RST requires a blank line before bullet lists for correct parsing. Signed-off-by: Clemens Volk <cvolk@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rework the concepts documentation to eliminate AI slop.