Fix daqp version in Arena dockerfile for compatibility with qpsolvers 4.12.0#667
Conversation
There was a problem hiding this comment.
Isaac Lab Review Bot 🤖
Summary: Clean and well-documented fix for qpsolvers 4.12.0 compatibility.
Review
✅ LGTM — This is a straightforward dependency version bump.
What the PR does:
- Adds
daqp==0.8.5installation to the Arena Dockerfile - Addresses Pink IK compatibility with qpsolvers 4.12.0
What I like:
- Clear comments explaining why this is needed
- References the upstream IsaacLab PR (#5556) for context
- Documents the specific commit hash after which this can be removed
- Uses
--upgrade --force-reinstallto ensure the version takes effect
Minor note: The pinned version 0.8.5 is the minimum required (>= 0.8.5 per upstream). If you want to be more future-proof, you could use daqp>=0.8.5, but pinning is also fine for reproducibility.
No concerns with this change. Ready to merge once CI passes.
Greptile SummaryThis PR pins
Confidence Score: 5/5Safe to merge — the change is a one-line, well-documented version pin with a clear removal condition. The fix is minimal and targeted: a single No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[isaaclab.sh -i\nInstalls qpsolvers + old daqp] --> B["[NEW] pip install --force-reinstall daqp==0.8.5\nUpgrades daqp to meet qpsolvers 4.12.0 requirement"]
B --> C[pip install isaacteleop~=1.1.0]
C --> D[pip install isaaclab_newton all]
D --> E[pip install av / msgpack / pyzmq]
E --> F["pip install -e workspace/[dev]"]
F --> G[Container ready]
Reviews (2): Last reviewed commit: "Update docker/Dockerfile.isaaclab_arena" | Re-trigger Greptile |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
#669) … 4.12.0 (#667) ## Summary Fixes compatibility of Pink IK with latest version of qpsolvers 4.12.0 which requires daqp >= 0.8.5. Isaac Lab has resolved this upstream in a [merged PR](isaac-sim/IsaacLab#5556). This PR updates the version of dqap in the Arena dockerfile manually. The change can be dropped after the Isaac Lab submodule is bumped past commit [4934cd0ce5a53b86342f32d89e5491016c841769](isaac-sim/IsaacLab@4934cd0). --------- ## Summary Short description of the change (max 50 chars) ## Detailed description - What was the reason for the change? - What has been changed? - What is the impact of this change? Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Summary
Fixes compatibility of Pink IK with latest version of qpsolvers 4.12.0 which requires daqp >= 0.8.5.
Isaac Lab has resolved this upstream in a merged PR. This PR updates the version of dqap in the Arena dockerfile manually. The change can be dropped after the Isaac Lab submodule is bumped past commit 4934cd0ce5a53b86342f32d89e5491016c841769.