Use typed configuration for local Experiments#892
Draft
cvolkcvolk wants to merge 5 commits into
Draft
Conversation
Keep eval_runner.py as the sole entry point while moving local orchestration behind typed configuration. This establishes the local half of a future local/OSMO router without changing existing camera or legacy JSON behavior. Signed-off-by: Clemens Volk <cvolk@nvidia.com>
cvolkcvolk
commented
Jul 10, 2026
cvolkcvolk
commented
Jul 10, 2026
cvolkcvolk
commented
Jul 10, 2026
Signed-off-by: Clemens Volk <cvolk@nvidia.com>
cvolkcvolk
changed the title
Signed-off-by: Clemens Volk <cvolk@nvidia.com>
cvolkcvolk
commented
Jul 12, 2026
| "--experiment-config", | ||
| "--experiment_config", | ||
| "--eval-jobs-config", | ||
| "--eval_jobs_config", |
Collaborator
Author
There was a problem hiding this comment.
Let's stick with only the underscore version
cvolkcvolk
commented
Jul 12, 2026
| help="Path to a typed YAML Experiment or deprecated JSON evaluation config.", | ||
| ) | ||
| parser.add_argument( | ||
| "--record-viewport-video", |
Collaborator
Author
There was a problem hiding this comment.
Lets keep the underscore version, here and for all other flags
Signed-off-by: Clemens Volk <cvolk@nvidia.com>
Signed-off-by: Clemens Volk <cvolk@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use typed configuration for local Experiment execution
Detailed description