Skip to content

Commit 16d6315

Browse files
authored
Remove stale xfail decorator from Newton environment tests (#5692)
Removed the stale file-level `@pytest.mark.xfail` decorator on `test_environments_newton` (the cited Hydra deep nesting issue was already resolved by PR #5029 and follow-ups #5130 / #5177). ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
1 parent 7df01a9 commit 16d6315

2 files changed

Lines changed: 6 additions & 8 deletions

File tree

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
Fixed
2+
^^^^^
3+
4+
* Removed the stale file-level ``@pytest.mark.xfail`` decorator on
5+
``test_environments_newton`` (the cited Hydra deep-nesting issue was already
6+
resolved by PR #5029 and follow-ups #5130 / #5177).

source/isaaclab_tasks/test/test_environments_newton.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,6 @@
3636
),
3737
)
3838
@pytest.mark.newton_ci
39-
@pytest.mark.xfail(
40-
reason=(
41-
"TODO: Nested PresetCfg resolution for named presets (e.g. 'newton_mjwarp') is not yet supported. "
42-
"The logic in parse_cfg.apply_named_preset should be unified with the deep-nesting "
43-
"fixes in https://github.com/isaac-sim/IsaacLab/pull/5029 (isaaclab_tasks.utils.hydra)."
44-
),
45-
strict=False,
46-
)
4739
def test_environments_newton(task_name, num_envs, device):
4840
# run environments with MJWarp physics preset
4941
_run_environments(task_name, device, num_envs, physics_preset_name="newton_mjwarp", create_stage_in_memory=False)

0 commit comments

Comments
 (0)