Commit 328854d
committed
Revert feet_slide defensive slicing; simplify Digit asset_cfg
The feet_slide change in 07265de added `asset_cfg.body_ids[:contacts.shape[1]]`
to work around an assumed Newton body-name duplication for closed-loop bodies.
Verified empirically: USD has 2 bodies matching `.*_leg_toe_roll` on both
backends; the regex does not over-match `.*_rod_roll` auxiliary joints. The
slicing was unnecessary and crashed with the default `SceneEntityCfg('robot')`
(where body_ids is `slice(None)`) — flagged by review bot.
Fixes:
- rewards.py: restore `body_lin_vel_w[:, asset_cfg.body_ids, :2]`
- digit/rough_env_cfg.py: restore regex `body_names='.*_leg_toe_roll'`
matching the sensor_cfg pattern; remove misleading comment.
Tested: Digit PhysX 10-iter and Digit Newton 5-iter both run feet_slide
without crashes.1 parent fdd2cbd commit 328854d
2 files changed
Lines changed: 2 additions & 5 deletions
File tree
- source/isaaclab_tasks/isaaclab_tasks/manager_based/locomotion/velocity
- config/digit
- mdp
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
53 | | - | |
| 52 | + | |
54 | 53 | | |
55 | 54 | | |
56 | 55 | | |
| |||
Lines changed: 1 addition & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
87 | | - | |
88 | | - | |
89 | | - | |
| 87 | + | |
90 | 88 | | |
91 | 89 | | |
92 | 90 | | |
| |||
0 commit comments