Skip to content

Commit 4085387

Browse files
authored
Adds more published docker image tags (#5417)
# Description Adds per-build immutable tags to the Docker images published by [.github/workflows/publish-images.yaml](.github/workflows/publish-images.yaml), and drops the bare commit-SHA tag (now redundant). New tags published: - `develop` builds: `$IMAGE:latest-develop-<run#>-<sha-stub>` (in addition to the existing `$IMAGE:latest-develop`) - `release/X` builds: `$IMAGE:latest-release-X-<run#>-<sha-stub>` (in addition to the existing `$IMAGE:latest-release-X`) Removed: `$IMAGE:<full-sha>`. The new run-number + short-SHA tags provide the same per-build immutability with a more readable tag name. `main` tagging (`$IMAGE:latest`, `$IMAGE:v<VERSION>`) is unchanged aside from the dropped SHA tag. The tagging-scheme comment in the workflow was updated to match. Fixes # (issue) ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
1 parent 301094d commit 4085387

1 file changed

Lines changed: 11 additions & 8 deletions

File tree

.github/workflows/publish-images.yaml

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -104,16 +104,18 @@ jobs:
104104
# Build the list of tags based on the branch.
105105
#
106106
# Tagging scheme:
107-
# - Every build: $IMAGE:<full-sha> (immutable, retained for re-testing)
108-
# - Push to develop: $IMAGE:latest-develop (moves to newest develop build)
109-
# - Push to release/X: $IMAGE:latest-release-X (moves to newest build on that release branch)
110-
# - Push to main: $IMAGE:latest (moves to newest main build)
111-
# $IMAGE:v<VERSION> (from the VERSION file, e.g. v3.0.0)
112-
TAGS=("$IMAGE:$SHA")
107+
# - Push to develop: $IMAGE:latest-develop (moves to newest develop build)
108+
# $IMAGE:latest-develop-<run#>-<sha-stub> (immutable per-build)
109+
# - Push to release/X: $IMAGE:latest-release-X (moves to newest build on that release branch)
110+
# $IMAGE:latest-release-X-<run#>-<sha-stub> (immutable per-build)
111+
# - Push to main: $IMAGE:latest (moves to newest main build)
112+
# $IMAGE:v<VERSION> (from the VERSION file, e.g. v3.0.0)
113+
TAGS=()
113114
114115
case "$BRANCH_NAME" in
115116
develop)
116117
TAGS+=("$IMAGE:latest-develop")
118+
TAGS+=("$IMAGE:latest-develop-${{ github.run_number }}-${SHA:0:8}")
117119
;;
118120
main)
119121
TAGS+=("$IMAGE:latest")
@@ -129,10 +131,11 @@ jobs:
129131
# Sanitize the part after release/ for use as a Docker tag suffix.
130132
RELEASE_SUFFIX=$(echo "${BRANCH_NAME#release/}" | sed 's/[^a-zA-Z0-9._-]/-/g')
131133
TAGS+=("$IMAGE:latest-release-$RELEASE_SUFFIX")
134+
TAGS+=("$IMAGE:latest-release-$RELEASE_SUFFIX-${{ github.run_number }}-${SHA:0:8}")
132135
;;
133136
*)
134-
# Other tracked branches only get the immutable sha tag.
135-
echo "Branch '$BRANCH_NAME' has no moving tag; only $IMAGE:$SHA will be published."
137+
echo "Branch '$BRANCH_NAME' is not configured for publishing; skipping."
138+
exit 0
136139
;;
137140
esac
138141

0 commit comments

Comments
 (0)