Commit 4b94eef
authored
Migrate OVPhysX FrameView + SceneDataBackend pose bindings onto OvPhysxView (view series) (#6233)
> ### 🔗 Stacked on top of #6224 (Part 1 — `OvPhysxView`)
> Branched off #6224 as a sibling of the asset/sensor migrations.
Targets `develop`; until #6224 merges the diff includes the Part 1
`OvPhysxView` commits. **Please review #6224 first.**
# Description
Two more `RIGID_BODY_POSE` binding consumers the asset (#6225-6227) and
sensor (#6228-6232) passes didn't cover, migrated together in one PR:
* **`OvPhysxFrameView`** (`sim/views/ovphysx_frame_view.py`) — the frame
view that cameras / `XformPrim` use. Builds one `OvPhysxView` +
`try_binding_for(RIGID_BODY_POSE)` (preserving its explicit "matched
zero bodies" error, since the view rejects a 0-count binding), and reads
via `read_into`.
* **`OvPhysxSceneDataBackend`** (`physics/ovphysx_manager.py`) — the
scene-data provider. Builds one `OvPhysxView` per distinct rigid-body
pattern, stores it on the per-pattern entry, and reads via `read_into`;
the per-entry merge into the transform buffer is unchanged.
Both are internal refactors — **no public API change** (neither exposes
a `root_view`). The `ContactBinding` is unrelated (separate wheel API;
see #6232). The scene-data backend's bypass-init unit test hand-seeds
the internal entry dict, so it now seeds a matching `view` stub with
`read_into`.
## Type of change
- [x] Internal refactor (non-breaking)
## Checklist
- [x] I have run the `pre-commit` checks with `./isaaclab.sh --format`
- [x] Changelog fragment (`.skip` — internal refactor, no bump)
## Testing
* `test_views_xform_prim_ovphysx.py` — cpu: **18 passed**, cuda: **18
passed**.
* `test_ovphysx_scene_data_backend.py` — **11 passed**.1 parent ab01ba0 commit 4b94eef
4 files changed
Lines changed: 17 additions & 5 deletions
File tree
- source/isaaclab_ovphysx
- changelog.d
- isaaclab_ovphysx
- physics
- sim/views
- test/physics
Whitespace-only changes.
Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
| 101 | + | |
101 | 102 | | |
102 | 103 | | |
103 | 104 | | |
| |||
119 | 120 | | |
120 | 121 | | |
121 | 122 | | |
122 | | - | |
| 123 | + | |
| 124 | + | |
123 | 125 | | |
124 | 126 | | |
125 | 127 | | |
| |||
141 | 143 | | |
142 | 144 | | |
143 | 145 | | |
| 146 | + | |
144 | 147 | | |
145 | 148 | | |
146 | 149 | | |
| |||
175 | 178 | | |
176 | 179 | | |
177 | 180 | | |
178 | | - | |
| 181 | + | |
179 | 182 | | |
180 | 183 | | |
181 | 184 | | |
| |||
Lines changed: 8 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
357 | 357 | | |
358 | 358 | | |
359 | 359 | | |
| 360 | + | |
360 | 361 | | |
361 | 362 | | |
362 | 363 | | |
| |||
406 | 407 | | |
407 | 408 | | |
408 | 409 | | |
409 | | - | |
410 | | - | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
411 | 415 | | |
412 | 416 | | |
413 | 417 | | |
414 | 418 | | |
415 | 419 | | |
416 | 420 | | |
417 | 421 | | |
| 422 | + | |
418 | 423 | | |
419 | 424 | | |
420 | 425 | | |
| |||
613 | 618 | | |
614 | 619 | | |
615 | 620 | | |
616 | | - | |
| 621 | + | |
617 | 622 | | |
618 | 623 | | |
619 | 624 | | |
| |||
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
186 | 186 | | |
187 | 187 | | |
188 | 188 | | |
| 189 | + | |
189 | 190 | | |
190 | 191 | | |
191 | 192 | | |
| |||
194 | 195 | | |
195 | 196 | | |
196 | 197 | | |
| 198 | + | |
197 | 199 | | |
198 | 200 | | |
199 | 201 | | |
| |||
324 | 326 | | |
325 | 327 | | |
326 | 328 | | |
| 329 | + | |
327 | 330 | | |
328 | 331 | | |
329 | 332 | | |
| |||
332 | 335 | | |
333 | 336 | | |
334 | 337 | | |
| 338 | + | |
335 | 339 | | |
336 | 340 | | |
337 | 341 | | |
| |||
0 commit comments