Skip to content

Commit 4d58ce4

Browse files
authored
Updates tests for Isaac Sim CI pipeline (#5403)
# Description Refines the list of CI tests that also get triggered in Isaac Sim CI. Ensures we are including tests covering rendering and physx that can be impacted by Isaac Sim and OV side changes. ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
1 parent 080898f commit 4d58ce4

31 files changed

Lines changed: 100 additions & 74 deletions

source/isaaclab/test/controllers/test_pink_ik.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@
3131
import isaaclab_tasks # noqa: F401
3232
from isaaclab_tasks.utils.parse_cfg import parse_env_cfg
3333

34+
pytestmark = pytest.mark.isaacsim_ci
35+
3436

3537
def load_test_config(env_name):
3638
"""Load test configuration based on environment type."""

source/isaaclab/test/controllers/test_pink_ik_components.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919

2020
from isaaclab.controllers.pink_ik.pink_kinematics_configuration import PinkKinematicsConfiguration
2121

22+
pytestmark = pytest.mark.isaacsim_ci
23+
2224

2325
class TestPinkKinematicsConfiguration:
2426
"""Test suite for PinkKinematicsConfiguration class."""

source/isaaclab/test/envs/test_env_rendering_logic.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@
3131
from isaaclab.sim import SimulationCfg, SimulationContext
3232
from isaaclab.utils import configclass
3333

34+
pytestmark = pytest.mark.isaacsim_ci
35+
3436

3537
@configclass
3638
class EmptyManagerCfg:

source/isaaclab/test/envs/test_video_recorder.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
from isaaclab.envs.utils import video_recorder as _video_recorder_module
1515
from isaaclab.envs.utils.video_recorder import VideoRecorder
1616

17+
pytestmark = pytest.mark.isaacsim_ci
1718
_BLANK_720p = np.zeros((720, 1280, 3), dtype=np.uint8)
1819
_DEFAULT_CFG = dict(
1920
env_render_mode="rgb_array",

source/isaaclab/test/performance/test_robot_load_performance.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,9 @@
3232
@pytest.mark.parametrize(
3333
"test_config,device",
3434
[
35-
({"name": "Cartpole", "robot_cfg": CARTPOLE_CFG, "expected_load_time": 10.0}, "cuda:0"),
36-
({"name": "Cartpole", "robot_cfg": CARTPOLE_CFG, "expected_load_time": 10.0}, "cpu"),
35+
# TODO: regression - this used to be 10
36+
({"name": "Cartpole", "robot_cfg": CARTPOLE_CFG, "expected_load_time": 15.0}, "cuda:0"),
37+
({"name": "Cartpole", "robot_cfg": CARTPOLE_CFG, "expected_load_time": 15.0}, "cpu"),
3738
# TODO: regression - this used to be 40
3839
({"name": "Anymal_D", "robot_cfg": ANYMAL_D_CFG, "expected_load_time": 55.0}, "cuda:0"),
3940
({"name": "Anymal_D", "robot_cfg": ANYMAL_D_CFG, "expected_load_time": 55.0}, "cpu"),

source/isaaclab/test/sensors/test_camera.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@
2929
import isaaclab.sim as sim_utils
3030
from isaaclab.sensors.camera import Camera, CameraCfg
3131

32+
pytestmark = pytest.mark.isaacsim_ci
33+
3234
# sample camera poses
3335
POSITION = (2.5, 2.5, 2.5)
3436
# Quaternions in xyzw format
@@ -827,7 +829,6 @@ def setup_camera_device(device):
827829

828830

829831
@pytest.mark.parametrize("device", ["cuda:0", "cpu"])
830-
@pytest.mark.isaacsim_ci
831832
def test_camera_multi_regex_init(setup_camera_device, device):
832833
"""Test multi-camera initialization with regex prim paths and content validation."""
833834
sim, camera_cfg, dt = setup_camera_device
@@ -869,7 +870,6 @@ def test_camera_multi_regex_init(setup_camera_device, device):
869870

870871

871872
@pytest.mark.parametrize("device", ["cuda:0", "cpu"])
872-
@pytest.mark.isaacsim_ci
873873
def test_camera_all_annotators(setup_camera_device, device):
874874
"""Test all supported annotators produce correct shapes, dtypes, content, and info."""
875875
sim, camera_cfg, dt = setup_camera_device
@@ -947,7 +947,6 @@ def test_camera_all_annotators(setup_camera_device, device):
947947

948948

949949
@pytest.mark.parametrize("device", ["cuda:0", "cpu"])
950-
@pytest.mark.isaacsim_ci
951950
def test_camera_segmentation_non_colorize(setup_camera_device, device):
952951
"""Test segmentation outputs with colorization disabled produce correct dtypes and info."""
953952
sim, camera_cfg, dt = setup_camera_device
@@ -978,7 +977,6 @@ def test_camera_segmentation_non_colorize(setup_camera_device, device):
978977

979978

980979
@pytest.mark.parametrize("device", ["cuda:0", "cpu"])
981-
@pytest.mark.isaacsim_ci
982980
def test_camera_normals_unit_length(setup_camera_device, device):
983981
"""Test that normals output vectors have approximately unit length."""
984982
sim, camera_cfg, dt = setup_camera_device
@@ -1008,7 +1006,6 @@ def test_camera_normals_unit_length(setup_camera_device, device):
10081006

10091007

10101008
@pytest.mark.parametrize("device", ["cuda:0", "cpu"])
1011-
@pytest.mark.isaacsim_ci
10121009
def test_camera_data_types_ordering(setup_camera_device, device):
10131010
"""Test that requesting specific data types produces the expected output keys."""
10141011
sim, camera_cfg, dt = setup_camera_device
@@ -1042,7 +1039,6 @@ def test_camera_data_types_ordering(setup_camera_device, device):
10421039

10431040

10441041
@pytest.mark.parametrize("device", ["cuda:0"])
1045-
@pytest.mark.isaacsim_ci
10461042
def test_camera_frame_offset(setup_camera_device, device):
10471043
"""Test that camera reflects scene color changes without frame-offset lag."""
10481044
sim, camera_cfg, dt = setup_camera_device

source/isaaclab/test/sensors/test_tiled_camera_env.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@
4141
import isaaclab_tasks # noqa: F401
4242
from isaaclab_tasks.utils.parse_cfg import parse_env_cfg
4343

44+
pytestmark = pytest.mark.isaacsim_ci
45+
4446

4547
@pytest.mark.skip(reason="Currently takes too long to run")
4648
def test_tiled_resolutions_tiny():

source/isaaclab/test/sim/test_cloner.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@
2525
from isaaclab.physics.scene_data_requirements import SceneDataRequirement, VisualizerPrebuiltArtifacts
2626
from isaaclab.sim import build_simulation_context
2727

28+
pytestmark = pytest.mark.isaacsim_ci
29+
2830

2931
@pytest.fixture(params=["cpu", "cuda"])
3032
def sim(request):

source/isaaclab/test/sim/test_mjcf_converter.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
from isaaclab.sim import SimulationCfg, SimulationContext
2323
from isaaclab.sim.converters import MjcfConverter, MjcfConverterCfg
2424

25+
pytestmark = pytest.mark.isaacsim_ci
26+
2527

2628
@pytest.fixture(autouse=True)
2729
def test_setup_teardown():
@@ -49,7 +51,6 @@ def test_setup_teardown():
4951
sim.clear_instance()
5052

5153

52-
@pytest.mark.isaacsim_ci
5354
def test_no_change(test_setup_teardown):
5455
"""Call conversion twice. This should not generate a new USD file."""
5556
sim, mjcf_config = test_setup_teardown
@@ -67,7 +68,6 @@ def test_no_change(test_setup_teardown):
6768
assert time_usd_file_created == new_time_usd_file_created
6869

6970

70-
@pytest.mark.isaacsim_ci
7171
def test_config_change(test_setup_teardown):
7272
"""Call conversion twice but change the config in the second call. This should generate a new USD file."""
7373
sim, mjcf_config = test_setup_teardown
@@ -87,7 +87,6 @@ def test_config_change(test_setup_teardown):
8787
assert time_usd_file_created != new_time_usd_file_created
8888

8989

90-
@pytest.mark.isaacsim_ci
9190
def test_create_prim_from_usd(test_setup_teardown):
9291
"""Call conversion and create a prim from it."""
9392
sim, mjcf_config = test_setup_teardown

source/isaaclab/test/sim/test_spawn_lights.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@
2121
from isaaclab.sim import SimulationCfg, SimulationContext
2222
from isaaclab.utils.string import to_camel_case
2323

24+
pytestmark = pytest.mark.isaacsim_ci
25+
2426

2527
@pytest.fixture(autouse=True)
2628
def sim():

0 commit comments

Comments
 (0)