Skip to content

Commit 71a205b

Browse files
committed
fixes
1 parent 4a2e8ed commit 71a205b

2 files changed

Lines changed: 23 additions & 27 deletions

File tree

source/isaaclab_newton/isaaclab_newton/cloner/newton_replicate.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ def _build_newton_builder_from_mapping(
5454

5555
builder = ModelBuilder(up_axis=up_axis)
5656
builder.default_body_armature = 0.001
57-
builder.default_shape_cfg.gap = 0.002
5857
stage_info = builder.add_usd(
5958
stage,
6059
ignore_paths=["/World/envs"] + sources,
@@ -68,7 +67,6 @@ def _build_newton_builder_from_mapping(
6867
for src_path in sources:
6968
p = ModelBuilder(up_axis=up_axis)
7069
p.default_body_armature = 0.001
71-
builder.default_shape_cfg.gap = 0.002
7270
solvers.SolverMuJoCo.register_custom_attributes(p)
7371
p.add_usd(
7472
stage,

source/isaaclab_tasks/isaaclab_tasks/manager_based/manipulation/dexsuite/dexsuite_env_cfg.py

Lines changed: 23 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -37,26 +37,32 @@
3737
)
3838

3939

40+
OBJECT_PHYSICS = {
41+
"physics_material": RigidBodyMaterialCfg(static_friction=0.5),
42+
"collision_props": sim_utils.CollisionPropertiesCfg(contact_offset=0.002),
43+
}
44+
45+
4046
@configclass
4147
class ObjectCfg(PresetCfg):
4248
shapes = sim_utils.MultiAssetSpawnerCfg(
4349
assets_cfg=[
44-
MeshCuboidCfg(size=(0.05, 0.1, 0.1), physics_material=RigidBodyMaterialCfg(static_friction=0.5)),
45-
MeshCuboidCfg(size=(0.05, 0.05, 0.1), physics_material=RigidBodyMaterialCfg(static_friction=0.5)),
46-
MeshCuboidCfg(size=(0.025, 0.1, 0.1), physics_material=RigidBodyMaterialCfg(static_friction=0.5)),
47-
MeshCuboidCfg(size=(0.025, 0.05, 0.1), physics_material=RigidBodyMaterialCfg(static_friction=0.5)),
48-
MeshCuboidCfg(size=(0.025, 0.025, 0.1), physics_material=RigidBodyMaterialCfg(static_friction=0.5)),
49-
MeshCuboidCfg(size=(0.01, 0.1, 0.1), physics_material=RigidBodyMaterialCfg(static_friction=0.5)),
50-
MeshSphereCfg(radius=0.05, physics_material=RigidBodyMaterialCfg(static_friction=0.5)),
51-
MeshSphereCfg(radius=0.025, physics_material=RigidBodyMaterialCfg(static_friction=0.5)),
52-
MeshCapsuleCfg(radius=0.04, height=0.025, physics_material=RigidBodyMaterialCfg(static_friction=0.5)),
53-
MeshCapsuleCfg(radius=0.04, height=0.01, physics_material=RigidBodyMaterialCfg(static_friction=0.5)),
54-
MeshCapsuleCfg(radius=0.04, height=0.1, physics_material=RigidBodyMaterialCfg(static_friction=0.5)),
55-
MeshCapsuleCfg(radius=0.025, height=0.1, physics_material=RigidBodyMaterialCfg(static_friction=0.5)),
56-
MeshCapsuleCfg(radius=0.025, height=0.2, physics_material=RigidBodyMaterialCfg(static_friction=0.5)),
57-
MeshCapsuleCfg(radius=0.01, height=0.2, physics_material=RigidBodyMaterialCfg(static_friction=0.5)),
58-
MeshConeCfg(radius=0.05, height=0.1, physics_material=RigidBodyMaterialCfg(static_friction=0.5)),
59-
MeshConeCfg(radius=0.025, height=0.1, physics_material=RigidBodyMaterialCfg(static_friction=0.5)),
50+
MeshCuboidCfg(size=(0.05, 0.1, 0.1), **OBJECT_PHYSICS),
51+
MeshCuboidCfg(size=(0.05, 0.05, 0.1), **OBJECT_PHYSICS),
52+
MeshCuboidCfg(size=(0.025, 0.1, 0.1), **OBJECT_PHYSICS),
53+
MeshCuboidCfg(size=(0.025, 0.05, 0.1), **OBJECT_PHYSICS),
54+
MeshCuboidCfg(size=(0.025, 0.025, 0.1), **OBJECT_PHYSICS),
55+
MeshCuboidCfg(size=(0.01, 0.1, 0.1), **OBJECT_PHYSICS),
56+
MeshSphereCfg(radius=0.05, **OBJECT_PHYSICS),
57+
MeshSphereCfg(radius=0.025, **OBJECT_PHYSICS),
58+
MeshCapsuleCfg(radius=0.04, height=0.025, **OBJECT_PHYSICS),
59+
MeshCapsuleCfg(radius=0.04, height=0.01, **OBJECT_PHYSICS),
60+
MeshCapsuleCfg(radius=0.04, height=0.1, **OBJECT_PHYSICS),
61+
MeshCapsuleCfg(radius=0.025, height=0.1, **OBJECT_PHYSICS),
62+
MeshCapsuleCfg(radius=0.025, height=0.2, **OBJECT_PHYSICS),
63+
MeshCapsuleCfg(radius=0.01, height=0.2, **OBJECT_PHYSICS),
64+
MeshConeCfg(radius=0.05, height=0.1, **OBJECT_PHYSICS),
65+
MeshConeCfg(radius=0.025, height=0.1, **OBJECT_PHYSICS),
6066
],
6167
rigid_props=sim_utils.RigidBodyPropertiesCfg(
6268
solver_position_iteration_count=16,
@@ -232,7 +238,7 @@ class StartupEventCfg:
232238
},
233239
)
234240

235-
object_physics_material = EventTerm(
241+
OBJECT_PHYSICS_material = EventTerm(
236242
func=mdp.randomize_rigid_body_material,
237243
mode="startup",
238244
params={
@@ -427,14 +433,6 @@ class DexsuiteReorientEnvCfg(ManagerBasedEnvCfg):
427433

428434
def validate_config(self):
429435
"""Check for invalid preset combinations after resolution."""
430-
is_newton = not isinstance(self.sim.physics, PhysxCfg)
431-
is_multi_asset = isinstance(self.scene.object.spawn, sim_utils.MultiAssetSpawnerCfg)
432-
433-
# if is_newton and is_multi_asset:
434-
# raise ValueError(
435-
# "Newton physics does not support multi-asset spawning."
436-
# " Use a single-geometry object preset (e.g. presets=cube) instead of 'shapes'."
437-
# )
438436

439437
warp_supported = {"rgb", "depth", "distance_to_image_plane"}
440438
for cam_attr in ("base_camera", "wrist_camera"):

0 commit comments

Comments
 (0)