Commit 9191147
committed
Address review feedback on collision pipeline config
Move config resolution out of NewtonManager into
NewtonCollisionPipelineCfg.to_pipeline_args(), following the Kamino
to_solver_config() pattern. Fix truthiness check on hydroelastic config
dict to use explicit `is not None`. Add missing changelog entry for
MJWarpSolverCfg.tolerance. Use specific return type hint dict[str, Any].1 parent 0d82b15 commit 9191147
3 files changed
Lines changed: 29 additions & 7 deletions
File tree
- source/isaaclab_newton
- docs
- isaaclab_newton/physics
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
12 | 21 | | |
13 | 22 | | |
14 | 23 | | |
| |||
Lines changed: 19 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
166 | 166 | | |
167 | 167 | | |
168 | 168 | | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
Lines changed: 1 addition & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
32 | 31 | | |
33 | 32 | | |
34 | 33 | | |
| |||
731 | 730 | | |
732 | 731 | | |
733 | 732 | | |
734 | | - | |
735 | | - | |
736 | | - | |
737 | | - | |
738 | | - | |
| 733 | + | |
739 | 734 | | |
740 | 735 | | |
741 | 736 | | |
| |||
0 commit comments