Commit ab01ba0
authored
Migrate OVPhysX contact-sensor pose binding onto OvPhysxView (view series, part 5) (#6232)
> ### 🔗 Stacked on top of #6224 (Part 1 — `OvPhysxView`)
> Branched off #6224 as a sibling of the other migrations. Targets
`develop`; until #6224 merges the diff includes the Part 1 `OvPhysxView`
commits. **Please review #6224 first.**
# Description
Part 5 of the OVPhysX view-migration series — the **contact sensor**.
This is the *partial* one: only the `RIGID_BODY_POSE` pose binding (the
`track_pose` path) is a `TensorBinding` the view can manage, so only it
is migrated. The **`ContactBinding`** (net forces via `read_net_forces`,
force matrix via `read_force_matrix`) is a separate ovphysx wheel API
that `OvPhysxView` does not wrap — it is left exactly as-is.
* `_initialize_impl` builds an `OvPhysxView` for the pose binding (when
`track_pose`) and obtains it via `binding_for(TT.RIGID_BODY_POSE)`; the
count-mismatch check and the `pose_binding` accessor are unchanged.
* The per-step pose read goes through `read_into(TT.RIGID_BODY_POSE,
...)` (cached reinterpret).
* The `ContactBinding` create/read/destroy paths are untouched.
* Internal refactor; no public API change.
## Type of change
- [x] Internal refactor (non-breaking)
## Checklist
- [x] I have run the `pre-commit` checks with `./isaaclab.sh --format`
- [x] My changes generate no new warnings
- [x] Changelog fragment (`.skip` — internal refactor, no bump)
## Testing
`test_contact_sensor.py` — cpu: **9 passed, 4 skipped**; cuda: **9
passed, 4 skipped** (exercises both the ContactBinding force path and
the migrated pose-tracking path).1 parent cb1fa8f commit ab01ba0
2 files changed
Lines changed: 10 additions & 5 deletions
File tree
- source/isaaclab_ovphysx
- changelog.d
- isaaclab_ovphysx/sensors/contact_sensor
Whitespace-only changes.
Lines changed: 10 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| |||
92 | 93 | | |
93 | 94 | | |
94 | 95 | | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
95 | 99 | | |
96 | 100 | | |
97 | 101 | | |
| |||
281 | 285 | | |
282 | 286 | | |
283 | 287 | | |
284 | | - | |
285 | | - | |
286 | | - | |
287 | | - | |
| 288 | + | |
| 289 | + | |
288 | 290 | | |
289 | 291 | | |
290 | 292 | | |
| |||
378 | 380 | | |
379 | 381 | | |
380 | 382 | | |
381 | | - | |
| 383 | + | |
382 | 384 | | |
383 | 385 | | |
384 | 386 | | |
| |||
518 | 520 | | |
519 | 521 | | |
520 | 522 | | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
521 | 526 | | |
0 commit comments