Skip to content

Commit c67ed38

Browse files
authored
Move rendering-correctness tests into dedicated CI jobs (#5649)
1 parent 9297faf commit c67ed38

3 files changed

Lines changed: 73 additions & 3 deletions

File tree

.github/workflows/build.yaml

Lines changed: 43 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,6 @@ jobs:
346346
isaacsim-base-image: ${{ needs.config.outputs.isaacsim_image_name }}
347347
isaacsim-version: ${{ needs.config.outputs.isaacsim_image_tag }}
348348
filter-pattern: "isaaclab_tasks"
349-
extra-pip-packages: "ovrtx"
350349
shard-index: "0"
351350
shard-count: "3"
352351
container-name: isaac-lab-tasks-1-test
@@ -369,7 +368,6 @@ jobs:
369368
isaacsim-base-image: ${{ needs.config.outputs.isaacsim_image_name }}
370369
isaacsim-version: ${{ needs.config.outputs.isaacsim_image_tag }}
371370
filter-pattern: "isaaclab_tasks"
372-
extra-pip-packages: "ovrtx"
373371
shard-index: "1"
374372
shard-count: "3"
375373
container-name: isaac-lab-tasks-2-test
@@ -392,7 +390,6 @@ jobs:
392390
isaacsim-base-image: ${{ needs.config.outputs.isaacsim_image_name }}
393391
isaacsim-version: ${{ needs.config.outputs.isaacsim_image_tag }}
394392
filter-pattern: "isaaclab_tasks"
395-
extra-pip-packages: "ovrtx"
396393
shard-index: "2"
397394
shard-count: "3"
398395
container-name: isaac-lab-tasks-3-test
@@ -696,6 +693,49 @@ jobs:
696693
filter-pattern: "isaaclab_tasks"
697694
include-files: "test_environments_training.py"
698695
container-name: isaac-lab-environments-training-test
696+
697+
test-rendering-correctness:
698+
name: "rendering-correctness"
699+
runs-on: [self-hosted, gpu]
700+
timeout-minutes: 120
701+
continue-on-error: true
702+
needs: [build, config]
703+
if: needs.build.result == 'success'
704+
steps:
705+
- uses: actions/checkout@v6
706+
with:
707+
fetch-depth: 1
708+
lfs: true
709+
- uses: ./.github/actions/run-package-tests
710+
with:
711+
image-tag: ${{ env.CI_IMAGE_TAG }}
712+
isaacsim-base-image: ${{ needs.config.outputs.isaacsim_image_name }}
713+
isaacsim-version: ${{ needs.config.outputs.isaacsim_image_tag }}
714+
filter-pattern: "isaaclab_tasks"
715+
include-files: "test_rendering_cartpole.py,test_rendering_dexsuite_kuka.py,test_rendering_registered_tasks.py,test_rendering_shadow_hand.py"
716+
container-name: isaac-lab-rendering-correctness-test
717+
718+
test-rendering-correctness-kitless:
719+
name: "rendering-correctness-kitless"
720+
runs-on: [self-hosted, gpu]
721+
timeout-minutes: 120
722+
continue-on-error: true
723+
needs: [build, config]
724+
if: needs.build.result == 'success'
725+
steps:
726+
- uses: actions/checkout@v6
727+
with:
728+
fetch-depth: 1
729+
lfs: true
730+
- uses: ./.github/actions/run-package-tests
731+
with:
732+
image-tag: ${{ env.CI_IMAGE_TAG }}
733+
isaacsim-base-image: ${{ needs.config.outputs.isaacsim_image_name }}
734+
isaacsim-version: ${{ needs.config.outputs.isaacsim_image_tag }}
735+
filter-pattern: "isaaclab_tasks"
736+
extra-pip-packages: "ovrtx"
737+
include-files: "test_rendering_cartpole_kitless.py,test_rendering_dexsuite_kuka_kitless.py,test_rendering_shadow_hand_kitless.py"
738+
container-name: isaac-lab-rendering-correctness-kitless-test
699739
#endregion
700740

701741
#region disabled quarantined tests
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
CI-only change. The rendering-correctness tests now run in two dedicated
2+
``test-rendering-correctness`` and ``test-rendering-correctness-kitless``
3+
jobs instead of being mixed into the ``isaaclab_tasks [N/3]`` shards.

tools/test_settings.py

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,29 @@
117117
quarantine them from regular CI.
118118
"""
119119

120+
RENDERING_CORRECTNESS_TESTS = [
121+
"test_rendering_cartpole.py",
122+
"test_rendering_dexsuite_kuka.py",
123+
"test_rendering_registered_tasks.py",
124+
"test_rendering_shadow_hand.py",
125+
]
126+
"""Rendering-correctness tests that run in-kit (non-kitless variants).
127+
128+
These tests are skipped in the generic ``isaaclab_tasks [N/3]`` CI jobs
129+
and run in the dedicated ``test-rendering-correctness`` CI job.
130+
"""
131+
132+
RENDERING_CORRECTNESS_KITLESS_TESTS = [
133+
"test_rendering_cartpole_kitless.py",
134+
"test_rendering_dexsuite_kuka_kitless.py",
135+
"test_rendering_shadow_hand_kitless.py",
136+
]
137+
"""Kitless rendering-correctness tests (OVRTX golden-image comparisons).
138+
139+
These tests are skipped in the generic ``isaaclab_tasks [N/3]`` CI jobs
140+
and run in the dedicated ``test-rendering-correctness-kitless`` CI job.
141+
"""
142+
120143
TESTS_TO_SKIP = [
121144
# lab
122145
"test_argparser_launch.py", # app.close issue
@@ -132,6 +155,10 @@
132155
# quarantined tests - run in dedicated CI job that does not block PR merges
133156
*QUARANTINED_TESTS,
134157
"test_environments_training.py", # Long-running RL training test; runs in dedicated CI job
158+
# rendering-correctness tests - run in dedicated test-rendering-correctness CI job
159+
*RENDERING_CORRECTNESS_TESTS,
160+
# kitless rendering-correctness tests - run in dedicated test-rendering-correctness-kitless CI job
161+
*RENDERING_CORRECTNESS_KITLESS_TESTS,
135162
]
136163
"""A list of tests to skip in CI (see conftest.py)."""
137164

0 commit comments

Comments
 (0)