Commit c958fdf
committed
Loosen rebuild-after-topology tolerance to 1e-5
The chained set_world_poses -> get_world_poses round-trip in
test_fabric_rebuild_after_topology_change goes through Warp's float32
SRT compose/decompose, which accumulates a few ULP of drift.
At the test's position magnitudes (~4-6), one float32 ULP is
~4.77e-7, so the prior atol of 1e-7 demanded sub-ULP agreement and
was sensitive to GPU/codegen variation -- it passed locally on the
A6000 but flaked in CI.
1e-5 corresponds to roughly 20 ULP at those magnitudes: tight enough
to catch any real bug (a wrong index or stale read would be at least
~1e-3 off given the test setup) and consistent with the shared
contract harness in frame_view_contract_utils.py, which already
documents and uses ATOL = 1e-5 for compose/decompose-through-float32
checks.1 parent f6479ad commit c958fdf
1 file changed
Lines changed: 2 additions & 1 deletion
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
209 | 209 | | |
210 | 210 | | |
211 | 211 | | |
212 | | - | |
| 212 | + | |
| 213 | + | |
213 | 214 | | |
214 | 215 | | |
215 | 216 | | |
| |||
0 commit comments