Commit d74e904
committed
Drop full_data and dead helpers from OVPhysX RigidObject
Address Antoine's PR #5426 review comments:
* Rename set_root_*_to_sim kernels to *_to_sim_index and drop the
from_mask flag plus unused root_*_state_w outputs (RigidObject does
not have those state buffers). Same simplification for
write_2d_data_to_buffer_with_indices, write_body_inertia_to_buffer,
and write_body_com_pose_to_buffer (renamed to *_index).
* Drop the full_data parameter from every *_index writer and setter on
RigidObject; index methods strictly accept partial data shaped
(len(env_ids), ...). Full-data callers should use the matching
*_mask overload. Matches Newton/PhysX convention.
* Replace the deprecated write_root_state_to_sim shims' use of the
internal _write_body_state plumbing with direct calls to the public
write_root_*_to_sim_index methods, mirroring PhysX/Newton.
* Remove the GPU-side write plumbing (_write_body_state,
_com_pose_to_link_pose, _to_flat_f32, _as_gpu_f32_2d,
_get_write_scratch, _stage_to_pinned_cpu, _binding_write,
_binding_read, _to_cpu_numpy, _to_cpu_indices,
_env_ids_to_gpu_warp, _n_envs_index) that those shims relied on.
* Remove the now-unused _compose_root_link_pose_from_com kernel; the
set_root_com_pose_to_sim_* kernels recover the link pose inline via
get_com_pose_in_link_frame_func.
* Remove the masses 1-D-to-(K, 1) auto-reshape from set_masses_index;
callers must pass shape (len(env_ids), len(body_ids)) explicitly.
* Reword every public docstring on RigidObject to follow the
Newton/PhysX template (one-line summary, .. note:: / .. tip:: blocks,
Args: block with shape/dtype on the parameter line).
test_rigid_body_set_mass updated to drop the now-unnecessary
masses.squeeze(-1) call (matches the Newton test's signature).
Bumps isaaclab_ovphysx 0.2.15 -> 0.2.16.1 parent 588c1c8 commit d74e904
5 files changed
Lines changed: 384 additions & 675 deletions
File tree
- source/isaaclab_ovphysx
- config
- docs
- isaaclab_ovphysx/assets
- rigid_object
- test/assets
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
4 | 49 | | |
5 | 50 | | |
6 | 51 | | |
| |||
0 commit comments