Skip to content

Commit e15b1d0

Browse files
authored
Enabled OVRTX rendering tests on CI (#5492)
# Description Enabled OVRTX rendering tests on CI. `OVRTX 0.3` is not published yet, so we have to use `OVRTX 0.2` render output as golden images. Some of them are incorrect, I will update those images when we pin to `OVRTX 0.3`. Fixes # (issue) <!-- As a practice, it is recommended to open an issue to have discussions on the proposed pull request. This makes it easier for the community to keep track of what is being developed or added, and if a given feature is demanded by more than one party. --> ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (existing functionality will not work without user modification) - Documentation update ## Screenshots Please attach before and after screenshots of the change if applicable. <!-- Example: | Before | After | | ------ | ----- | | _gif/png before_ | _gif/png after_ | To upload images to a PR -- simply drag and drop an image while in edit mode and it should upload the image directly. You can then paste that source into the above before/after sections. --> ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
1 parent 513a017 commit e15b1d0

25 files changed

Lines changed: 58 additions & 51 deletions

.github/workflows/build.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -256,6 +256,7 @@ jobs:
256256
isaacsim-base-image: ${{ needs.config.outputs.isaacsim_image_name }}
257257
isaacsim-version: ${{ needs.config.outputs.isaacsim_image_tag }}
258258
filter-pattern: "isaaclab_tasks"
259+
extra-pip-packages: "ovrtx"
259260
shard-index: "0"
260261
shard-count: "3"
261262
container-name: isaac-lab-tasks-1-test
@@ -278,6 +279,7 @@ jobs:
278279
isaacsim-base-image: ${{ needs.config.outputs.isaacsim_image_name }}
279280
isaacsim-version: ${{ needs.config.outputs.isaacsim_image_tag }}
280281
filter-pattern: "isaaclab_tasks"
282+
extra-pip-packages: "ovrtx"
281283
shard-index: "1"
282284
shard-count: "3"
283285
container-name: isaac-lab-tasks-2-test
@@ -300,6 +302,7 @@ jobs:
300302
isaacsim-base-image: ${{ needs.config.outputs.isaacsim_image_name }}
301303
isaacsim-version: ${{ needs.config.outputs.isaacsim_image_tag }}
302304
filter-pattern: "isaaclab_tasks"
305+
extra-pip-packages: "ovrtx"
303306
shard-index: "2"
304307
shard-count: "3"
305308
container-name: isaac-lab-tasks-3-test

.github/workflows/daily-compatibility.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@ jobs:
111111
image-tag: ${{ env.DOCKER_IMAGE_TAG }}
112112
pytest-options: ""
113113
filter-pattern: "isaaclab_tasks"
114+
extra-pip-packages: "ovrtx"
114115

115116
- name: Copy All Test Results from IsaacLab Tasks Container
116117
run: |

docs/source/setup/installation/kitless_installation.rst

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,6 @@ OVRTX provides GPU-accelerated rendering for vision tasks without Kit.
105105
106106
./isaaclab.sh -i ov[ovrtx]
107107
108-
export LD_PRELOAD=$(python -c "import ovrtx, pathlib; print(pathlib.Path(ovrtx.__file__).parent / 'bin/plugins/libcarb.so')")
109-
110108
./isaaclab.sh -p scripts/benchmarks/benchmark_rsl_rl.py \
111109
--task Isaac-Repose-Cube-Shadow-Vision-Benchmark-Direct-v0 \
112110
--headless --enable_cameras --num_envs 16 --max_iterations 10 \
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
Fixed
2+
^^^^^
3+
4+
* Set ``keep_system_alive=True`` on the internal OVRTX ``RendererConfig`` in
5+
:class:`~isaaclab_ov.renderers.ovrtx_renderer.OVRTXRenderer` so the renderer
6+
system is not torn down prematurely during pytest sessions.

source/isaaclab_ov/isaaclab_ov/renderers/ovrtx_renderer.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -201,6 +201,7 @@ def initialize(self, spec: CameraRenderSpec):
201201
log_file_path=self.cfg.log_file_path,
202202
log_level=self.cfg.log_level,
203203
read_gpu_transforms=_IS_OVRTX_0_3_0_OR_NEWER,
204+
keep_system_alive=True,
204205
)
205206
self._renderer = Renderer(OVRTX_CONFIG)
206207
assert self._renderer, "Renderer should be valid after creation"

source/isaaclab_tasks/changelog.d/huidongc-enable-ovrtx-rendering.skip

Whitespace-only changes.
Lines changed: 2 additions & 2 deletions
Loading
Lines changed: 2 additions & 2 deletions
Loading
Lines changed: 1 addition & 1 deletion
Loading
Lines changed: 2 additions & 2 deletions
Loading

0 commit comments

Comments
 (0)