-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Adding Hydroelastic and SDF collision configuration to IsaacLab #5160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vidurv-nvidia
wants to merge
20
commits into
isaac-sim:develop
Choose a base branch
from
vidurv-nvidia:vidur/feature/sdf-collision
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
c62f718
Add show collision mesh toggle to Newton viewer
vidurv-nvidia d232e02
Update source/isaaclab_visualizers/isaaclab_visualizers/newton/newton…
vidurv-nvidia 0d0d99a
Update source/isaaclab_visualizers/isaaclab_visualizers/newton/newton…
vidurv-nvidia 9e6d2ff
Update newton_visualizer_cfg.py
vidurv-nvidia 2ec08d9
Remove duplicate variable definitions in NewtonVisualizerCfg
vidurv-nvidia 82e14f9
Add show inertia boxes toggle to Newton viewer
vidurv-nvidia 803da43
Add SDF and Hydroelastic collisions in ISaacLab
vidurv-nvidia c195a2a
Integrate Octi's changes to the collision pipline creation from https…
vidurv-nvidia 2331815
Add unit tests for SDF and Hydroelastic configuration
vidurv-nvidia 9a2b417
Update source/isaaclab_newton/isaaclab_newton/physics/newton_manager.py
vidurv-nvidia b8afb8b
Move the import to the top level
vidurv-nvidia 114c25a
Make config variable access consistent
vidurv-nvidia 9aaeff8
Update body and shape pattern matching
vidurv-nvidia e48fbf6
Apply SDF mesh conversion before the enviorment is replicated
vidurv-nvidia a0ac249
Raise TypeError for invalid collision_cfg instead of silent fallback
vidurv-nvidia 91cf1b9
Guard against None PhysicsManager._cfg in _apply_sdf_config
vidurv-nvidia b7c2c76
Fix lint and formatting issues from pre-commit
vidurv-nvidia bd1189d
Merge branch 'vidur/feature/newton-viewer-collision' into vidur/featu…
vidurv-nvidia 9b112c7
Add show visual geometries toggle to Newton viewer
vidurv-nvidia 3fca0dc
Fix SDF config bugs: skip redundant rebuilds, respect hydro patterns,…
vidurv-nvidia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_apply_sdf_configcrashes whenPhysicsManager._cfgisNone_apply_sdf_config(p)is called unconditionally for every prototype here, but inside_apply_sdf_config, the first two lines are:There is no
Noneguard oncfg. Meanwhile, the code added just above in this same function (lines 77–78) explicitly guards againstcfgbeingNone:This inconsistency means: in the exact scenario the replicate code considers valid (where
PhysicsManager._cfgisNone), calling_apply_sdf_config(p)unconditionally will raiseAttributeError: 'NoneType' object has no attribute 'sdf_cfg'.The simplest fix is to add the same guard inside
_apply_sdf_config: