-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Improves hanging flakiness in CI tests #5479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kellyguo11
merged 12 commits into
isaac-sim:develop
from
kellyguo11:test-articulation-timeout
May 5, 2026
Merged
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
cc7bb1b
debug timeout tests
kellyguo11 5a37730
more debug
kellyguo11 7296571
more debug
kellyguo11 c9a364b
continue debug
kellyguo11 0f09c3b
Merge branch 'develop' into test-articulation-timeout
kellyguo11 bbb6953
fix
kellyguo11 2687576
Merge branch 'test-articulation-timeout' of github.com:kellyguo11/Isa…
kellyguo11 afb26fb
fix again
kellyguo11 1488ff4
debug
kellyguo11 4a15941
clean up debug
kellyguo11 f741802
Merge branch 'develop' into test-articulation-timeout
kellyguo11 b46f04f
add changelog fragment
kellyguo11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two
printcalls are placed inside the 100-step inner loop (beforewrite_data_to_simand afterarticulation.update). With-scapturing disabled and 5 outer iterations, that is at minimum 1 000 lines per(device, num_articulations)combination. Across all parameterized combinations this becomes very verbose. Moving these traces outside the inner loop, or gating them with astep_i % 10 == 0condition, would preserve diagnostic value without flooding logs.