Updating docs, explicitly call out physicx support and handtracking r…#5494
Conversation
There was a problem hiding this comment.
🤖 Isaac Lab Review Bot
Summary
This PR updates documentation to clarify that Newton physics backend is not supported for real-time teleoperation, explicitly adding physx preset annotations to teleop environment entries. It also adds a helpful tip about hand tracking input modes to the CloudXR guide and cleans up duplicate entries in the comprehensive environment list.
Architecture Impact
Self-contained. This is a documentation-only change with no code impact. The changes correctly inform users about physics backend requirements for teleoperation workflows.
Implementation Verdict
Minor fixes needed
Test Coverage
Not applicable — documentation-only PR. The checklist item "I have added tests that prove my fix is effective or that my feature works" is checked but no tests are needed for doc changes.
CI Status
No CI checks available yet. Documentation changes should pass standard CI once triggered.
Findings
🔵 Improvement: docs/source/overview/environments.rst:1108-1112 — Missing entry context
The newly added Isaac-Stack-Cube-Franka-IK-Abs-v0 entry is placed between unrelated environments (after the Dexsuite section header comment area). While technically valid RST, this appears to be inserted somewhat arbitrarily. Consider grouping with other Franka Stack entries for consistency, though the table is alphabetically organized in sections so this may be intentional.
🔵 Improvement: docs/source/overview/environments.rst:1161-1206 — Duplicate removal verification needed
The diff shows removal of duplicate Galbot/Agibot rows, but the resulting structure has Isaac-Stack-Cube-Galbot-Left-Arm-Gripper-RmpFlow-v0 appearing at line 1203 and Isaac-Stack-Cube-Galbot-Right-Arm-Suction-RmpFlow-v0 at lines 1196 and 1209. Looking at the full context, there appear to be entries for:
Isaac-Stack-Cube-Galbot-Left-Arm-Gripper-RmpFlow-v0(line 1203)Isaac-Stack-Cube-Galbot-Right-Arm-Suction-RmpFlow-v0(line 1209)Isaac-Stack-Cube-Galbot-Left-Arm-Gripper-Visuomotor-v0(line 1213)
The full file is truncated at 30K chars, making it impossible to fully verify duplicate removal was complete. The author should confirm no duplicates remain.
🟡 Warning: docs/source/overview/environments.rst — Inconsistent preset documentation
Several similar manipulation environments have inconsistent preset documentation:
Isaac-Place-Mug-Agibot-Left-Arm-RmpFlow-v0(line 1217) has no preset listedIsaac-Place-Toy2Box-Agibot-Right-Arm-RmpFlow-v0was removed but Agibot entries in the visual table (lines 193-196) still show no presets
If Newton is truly not supported for teleoperation environments, shouldn't the Agibot entries also have physx specified, or is there a reason they differ? The PR description mentions "Newton is not supported for real-time teleoperation in this release" but doesn't clarify which specific environments this applies to.
🔵 Improvement: docs/source/how-to/cloudxr_teleoperation.rst:123-128 — Cross-reference validation
The tip references :ref:isaac-teleop-control-schemes`` which should link to a table documenting input modes per task. This is good documentation practice. However, ensure this anchor exists and the linked table is up-to-date with the newly documented environments.
🔵 Improvement: docs/source/overview/environments.rst — Missing physx preset on OpenArm entries
The OpenArm manipulation entries (lines 197-208 in the visual table) show no presets. If these are also teleoperation-capable environments, should they also have physx specified for consistency with the stated goal of this PR?
Greptile SummaryThis is a documentation-only PR that updates the environments reference and CloudXR teleoperation guide to clarify PhysX backend requirements for real-time teleoperation (Newton is unsupported for teleop in this release). Changes include adding the Confidence Score: 5/5Documentation-only change with no code or logic modifications; safe to merge. All changes are RST documentation updates: physx presets are added consistently to identified teleop environments, duplicate rows are cleanly removed, the new cross-reference in cloudxr_teleoperation.rst resolves to a valid label, and no code paths are affected. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Teleop Environment Launch] --> B{PhysX backend?}
B -- Yes --> C[Supported: GR1T2, G1, Galbot,\nFranka IK-Abs, NutPour,\nExhaustPipe, Locomanipulation G1,\nFixedBase G1]
B -- No / Newton --> D[Not supported for\nreal-time teleoperation]
C --> E{Input mode?}
E -- Hand Tracking --> F[Isaac-PickPlace-GR1T2-WaistEnabled-Abs-v0\n+ others — enable XR hand tracking]
E -- Motion Controllers --> G[Other teleop environments]
Reviews (1): Last reviewed commit: "Updating docs, explicitly call out physi..." | Re-trigger Greptile |
…equirment for teleop envs
e68bb56 to
e243116
Compare
There was a problem hiding this comment.
🤖 Isaac Lab Review Bot
Summary
This is a follow-up review. Comparing the new commit against the previous review, the changes are identical — no new commits have been pushed since the last review.
Previous Findings Status
All previous findings remain applicable as no changes were made to address them:
- The inconsistent preset documentation for Agibot entries is still present
- The OpenArm entries still lack
physxpresets - The duplicate verification concern cannot be fully validated due to file truncation
Implementation Verdict
Ship it — this is a documentation-only PR that achieves its stated goal of clarifying PhysX support for teleoperation environments. The previous findings were all 🔵 improvements or clarification requests rather than blocking issues. The core documentation updates are correct and helpful for users.
Description
Newton is not supported for real-time teleoperation in this release. Update the environments documentation to list the physx preset for all teleop environments so users know which physics backend to use.
Add physx preset to GR1, G1, Galbot, and Franka IK-Abs teleop entries in the visual environment table
Add missing teleop environments to the comprehensive list (PickPlace GR1T2, NutPour, ExhaustPipe, Locomanipulation G1, FixedBase G1, Stack-Cube-Franka-IK-Abs)
Add physx preset to existing Galbot stack entries in the comprehensive list
Remove duplicate Galbot/Agibot rows in the comprehensive list
Add a tip about hand tracking input mode to the CloudXR teleoperation guide
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there