Locks qpsolvers version to be last known compatible version with PINK IK#5555
Locks qpsolvers version to be last known compatible version with PINK IK#5555peterd-NV wants to merge 1 commit intoisaac-sim:developfrom
Conversation
Greptile SummaryThis PR pins
Confidence Score: 5/5Safe to merge; the change is a one-line dependency pin with no logic modifications. The only change is adding qpsolvers==4.11.0 under the same platform guard already used for the other pink_ik dependencies. It correctly prevents pip from picking up the incompatible 4.12.0 release that caused a silent IK no-op. The changelog fragment is accurate and follows the existing format. No files require special attention; the changelog entry has a minor style inconsistency (missing Changed section) but does not affect functionality. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["pip install isaaclab (Linux ARM/x86)"] --> B["Resolves qpsolvers"]
B -- "Before PR (unconstrained)" --> C["qpsolvers>=4.12.0 installed"]
C --> D["pin-pink==3.1.0 calls solve_ik()"]
D --> E["TypeError: unexpected kwarg 'primal_start'"]
E --> F["PinkIKController silently returns current joints (IK no-op)"]
B -- "After PR (qpsolvers==4.11.0)" --> G["qpsolvers 4.11.0 installed"]
G --> H["pin-pink==3.1.0 calls solve_ik()"]
H --> I["IK solved correctly"]
Reviews (1): Last reviewed commit: "lock qpsolvers version to be last known ..." | Re-trigger Greptile |
| * Pinned ``qpsolvers==4.11.0`` to keep Pink IK working. ``qpsolvers`` 4.12.0 | ||
| dropped the ``primal_start`` kwarg, causing ``pin-pink==3.1.0`` to raise | ||
| ``TypeError`` inside ``solve_ik``; | ||
| :class:`~isaaclab.controllers.pink_ik.PinkIKController` then silently | ||
| fell back to returning the current joints, making IK a no-op. |
There was a problem hiding this comment.
Other entries that add a new install requirement (e.g.,
antoiner-fix-from-files-windows-filelock.rst) include a Changed section alongside the Fixed section to record the added dependency. Adding one here would keep the changelog consistent.
| * Pinned ``qpsolvers==4.11.0`` to keep Pink IK working. ``qpsolvers`` 4.12.0 | |
| dropped the ``primal_start`` kwarg, causing ``pin-pink==3.1.0`` to raise | |
| ``TypeError`` inside ``solve_ik``; | |
| :class:`~isaaclab.controllers.pink_ik.PinkIKController` then silently | |
| fell back to returning the current joints, making IK a no-op. | |
| * Pinned ``qpsolvers==4.11.0`` to keep Pink IK working. ``qpsolvers`` 4.12.0 | |
| dropped the ``primal_start`` kwarg, causing ``pin-pink==3.1.0`` to raise | |
| ``TypeError`` inside ``solve_ik``; | |
| :class:`~isaaclab.controllers.pink_ik.PinkIKController` then silently | |
| fell back to returning the current joints, making IK a no-op. | |
| Changed | |
| ^^^^^^^ | |
| * Added ``qpsolvers==4.11.0`` to ``isaaclab`` install requirements (Linux only). |
|
Looks like @ooctipus was able to fix the tests in #5556. @peterd-NV do those changes look good to you? |
Description
Locks the version of qpsolvers to 4.11.0 which is last known version that works with pin_pink.
This fixes Pink IK tests.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there