Skip to content

Fix LeappDeploymentEnv missing extras attribute #5560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
klakhi wants to merge 1 commit into
base: develop
Choose a base branch
from
+7 −0
Open

Fix LeappDeploymentEnv missing extras attribute #5560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions source/isaaclab/changelog.d/klakhi-fix-leapp-deployment-env-extras.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Fixed
^^^^^

* Fixed :class:`~envs.LeappDeploymentEnv` crashing on ``reset()`` with
``AttributeError: 'LeappDeploymentEnv' object has no attribute 'extras'``
by initializing ``self.extras`` in ``__init__``.
1 change: 1 addition & 0 deletions source/isaaclab/isaaclab/envs/leapp_deployment_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ def __init__(self, cfg: Any, leapp_yaml_path: str):
self._leapp_yaml_path = leapp_yaml_path
self._step_count = 0
self._sim_step_counter = 0
self.extras: dict = {}
Copy link
Copy Markdown

@isaaclab-review-bot isaaclab-review-bot Bot May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Consider type annotation: For consistency with other env classes, you could add the type annotation inline:

Suggested change
self.extras: dict = {}
self.extras: dict[str, Any] = {}

Minor nit — the current form is fine.


# ── Simulation + scene ────────────────────────────────────
self.sim = SimulationContext(cfg.sim)
Expand Down
Loading