Fix broken external links flagged by lychee#5576
Conversation
robosuite.ai now returns 404; point to the project's GitHub repo instead. The Manus plugin README at IsaacTeleop/blob/main/src/plugins/manus/README.md has been moved or removed; redirect readers to the Isaac Teleop repo root.
There was a problem hiding this comment.
✅ Looks Good
Clean fix for the two broken links flagged by lychee.
Changes verified:
docs/source/setup/ecosystem.rst: RoboSuite link updated fromrobosuite.ai(404) → GitHub repo. ✓docs/source/how-to/cloudxr_teleoperation.rst: Dead Manus plugin README link → Isaac Teleop repo root. ✓
Both replacement URLs resolve correctly. The Isaac Teleop repo root is a reasonable fallback until the Manus docs are republished upstream.
No concerns — straightforward link maintenance.
Greptile SummaryThis PR fixes two broken external links caught by the lychee Documentation Links CI job — replacing a deleted Manus plugin README path in
Confidence Score: 4/5Documentation-only change with no runtime impact; the IsaacTeleop fix is solid, but the robosuite.ai link replacement warrants a quick re-check before merging. The Manus plugin link update is straightforward — the upstream path is gone and the repo root is a valid temporary target. The robosuite.ai swap is less clear-cut: external lookups show the domain still serving content, and the GitHub repo itself lists robosuite.ai as the canonical project homepage, so the replacement may be unnecessary or even a regression in link quality. No code logic is touched. docs/source/setup/ecosystem.rst — the robosuite.ai domain should be re-verified to confirm it is actually returning 404 before the link is permanently changed to the GitHub repo. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[lychee CI scan] -->|ERROR: 404| B[robosuite.ai]
A -->|ERROR: 404| C[IsaacTeleop Manus README path]
B --> D["ecosystem.rst\nRoboSuite link"]
C --> E["cloudxr_teleoperation.rst\nManus plugin link"]
D -->|Updated to| F[github.com/ARISE-Initiative/robosuite]
E -->|Updated to| G[github.com/NVIDIA/IsaacTeleop root]
F -->|Note| H{robosuite.ai\nstill reachable?}
H -->|Yes - re-verify| I[Consider reverting to canonical homepage]
H -->|No - confirmed dead| J[GitHub repo is correct fallback]
Reviews (1): Last reviewed commit: "Fix broken external links flagged by lyc..." | Re-trigger Greptile |
| .. _ManiSkill: https://github.com/haosulab/ManiSkill | ||
| .. _ThreeDWorld: https://www.threedworld.org/ | ||
| .. _RoboSuite: https://robosuite.ai/ | ||
| .. _RoboSuite: https://github.com/ARISE-Initiative/robosuite |
There was a problem hiding this comment.
Possibly premature link replacement —
https://robosuite.ai/ appears to still be reachable. Web lookups return the full robosuite homepage content, and the GitHub repo itself (ARISE-Initiative/robosuite) lists robosuite.ai as the project's canonical website. Pointing readers to the GitHub repo instead of the project's own homepage is a downgrade in documentation quality; if lychee flagged it, it may have been a transient failure or a redirect that lychee doesn't follow. Consider re-checking the URL before merging — if it truly resolves now, the original link is preferable.
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
Summary
docs/source/setup/ecosystem.rst:https://robosuite.ai/now returns 404. Updated the RoboSuite reference link to the project's GitHub repo (https://github.com/ARISE-Initiative/robosuite).docs/source/how-to/cloudxr_teleoperation.rst:https://github.com/NVIDIA/IsaacTeleop/blob/main/src/plugins/manus/README.mdis gone (404). The IsaacTeleop repo root still resolves, so the Manus plugin reference now points there until the upstream doc is republished.These were the two failures from the
Documentation LinksCI job; everything else lychee reported was a 301/302 redirect already in the accept list.Test plan
pre-commit run --files docs/source/how-to/cloudxr_teleoperation.rst docs/source/setup/ecosystem.rst— passes.Documentation Linkson the PR — expect zero[ERROR]entries.