Skip to content

Draft: testing #5701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huidongc wants to merge 2 commits into from
+1 −1
Closed

Draft: testing #5701

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a1c45b
testing
huidongc May 20, 2026
7913f4e
revert change
huidongc May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@
# Shared image config for CI workflows. Loaded by the `config` job in each
# workflow via yq and exposed as job outputs (see e.g. .github/workflows/build.yaml).
isaacsim_image_name: nvcr.io/nvidian/isaac-sim
isaacsim_image_tag: latest-develop@sha256:0dd49a1121b297dc85eee7777a9c528318683dbe03b29fd01f2059ac1b099301
isaacsim_image_tag: latest-develop

@greptile-apps greptile-apps Bot May 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Unpinned mutable image tag removes CI reproducibility

The image tag was changed from a SHA-digest-pinned reference (latest-develop@sha256:0dd49a...) to the floating tag latest-develop. Floating tags are mutable — if the upstream nvcr.io/nvidian/isaac-sim:latest-develop image is updated, every subsequent CI run silently picks up the new image without any code change, making failures hard to bisect and test results non-reproducible. The original SHA digest was clearly there to guarantee a stable, immutable build environment.

isaaclab_image_name: nvcr.io/nvidian/isaac-lab
Loading