Skip to content

Commit 274f5c2

Browse files
chore(internal): support x-stainless-mcp-client-envs header in MCP servers
1 parent 6e1fbb2 commit 274f5c2

4 files changed

Lines changed: 43 additions & 15 deletions

File tree

packages/mcp-server/src/code-tool.ts

Lines changed: 25 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -148,19 +148,23 @@ const remoteStainlessHandler = async ({
148148

149149
const codeModeEndpoint = readEnv('CODE_MODE_ENDPOINT_URL') ?? 'https://api.stainless.com/api/ai/code-tool';
150150

151+
const localClientEnvs = {
152+
ISAACUS_API_KEY: requireValue(
153+
readEnv('ISAACUS_API_KEY') ?? client.apiKey,
154+
'set ISAACUS_API_KEY environment variable or provide apiKey client option',
155+
),
156+
ISAACUS_BASE_URL: readEnv('ISAACUS_BASE_URL') ?? client.baseURL ?? undefined,
157+
};
158+
// Merge any upstream client envs from the request header, with upstream values taking precedence.
159+
const mergedClientEnvs = { ...localClientEnvs, ...reqContext.upstreamClientEnvs };
160+
151161
// Setting a Stainless API key authenticates requests to the code tool endpoint.
152162
const res = await fetch(codeModeEndpoint, {
153163
method: 'POST',
154164
headers: {
155165
...(reqContext.stainlessApiKey && { Authorization: reqContext.stainlessApiKey }),
156166
'Content-Type': 'application/json',
157-
'x-stainless-mcp-client-envs': JSON.stringify({
158-
ISAACUS_API_KEY: requireValue(
159-
readEnv('ISAACUS_API_KEY') ?? client.apiKey,
160-
'set ISAACUS_API_KEY environment variable or provide apiKey client option',
161-
),
162-
ISAACUS_BASE_URL: readEnv('ISAACUS_BASE_URL') ?? client.baseURL ?? undefined,
163-
}),
167+
'x-stainless-mcp-client-envs': JSON.stringify(mergedClientEnvs),
164168
},
165169
body: JSON.stringify({
166170
project_name: 'isaacus',
@@ -271,6 +275,9 @@ const localDenoHandler = async ({
271275
printOutput: true,
272276
spawnOptions: {
273277
cwd: path.dirname(workerPath),
278+
// Merge any upstream client envs into the Deno subprocess environment,
279+
// with the upstream env vars taking precedence.
280+
env: { ...process.env, ...reqContext.upstreamClientEnvs },
274281
},
275282
});
276283

@@ -280,13 +287,17 @@ const localDenoHandler = async ({
280287
reject(new Error(`Worker exited with code ${exitCode}`));
281288
});
282289

283-
const opts: ClientOptions = {
284-
baseURL: client.baseURL,
285-
apiKey: client.apiKey,
286-
defaultHeaders: {
287-
'X-Stainless-MCP': 'true',
288-
},
289-
};
290+
// Strip null/undefined values so that the worker SDK client can fall back to
291+
// reading from environment variables (including any upstreamClientEnvs).
292+
const opts: ClientOptions = Object.fromEntries(
293+
Object.entries({
294+
baseURL: client.baseURL,
295+
apiKey: client.apiKey,
296+
defaultHeaders: {
297+
'X-Stainless-MCP': 'true',
298+
},
299+
}).filter(([_, v]) => v != null),
300+
) as ClientOptions;
290301

291302
const req = worker.request(
292303
'http://localhost',

packages/mcp-server/src/http.ts

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,19 @@ const newServer = async ({
2727

2828
const authOptions = parseClientAuthHeaders(req, false);
2929

30+
let upstreamClientEnvs: Record<string, string> | undefined;
31+
const clientEnvsHeader = req.headers['x-stainless-mcp-client-envs'];
32+
if (typeof clientEnvsHeader === 'string') {
33+
try {
34+
const parsed = JSON.parse(clientEnvsHeader);
35+
if (parsed && typeof parsed === 'object' && !Array.isArray(parsed)) {
36+
upstreamClientEnvs = parsed;
37+
}
38+
} catch {
39+
// Ignore malformed header
40+
}
41+
}
42+
3043
await initMcpServer({
3144
server: server,
3245
mcpOptions: mcpOptions,
@@ -35,6 +48,7 @@ const newServer = async ({
3548
...authOptions,
3649
},
3750
stainlessApiKey: stainlessApiKey,
51+
upstreamClientEnvs,
3852
});
3953

4054
return server;
@@ -72,7 +86,7 @@ const del = async (req: express.Request, res: express.Response) => {
7286
};
7387

7488
const redactHeaders = (headers: Record<string, any>) => {
75-
const hiddenHeaders = /auth|cookie|key|token/i;
89+
const hiddenHeaders = /auth|cookie|key|token|x-stainless-mcp-client-envs/i;
7690
const filtered = { ...headers };
7791
Object.keys(filtered).forEach((key) => {
7892
if (hiddenHeaders.test(key)) {

packages/mcp-server/src/server.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ export async function initMcpServer(params: {
3737
clientOptions?: ClientOptions;
3838
mcpOptions?: McpOptions;
3939
stainlessApiKey?: string | undefined;
40+
upstreamClientEnvs?: Record<string, string> | undefined;
4041
}) {
4142
const server = params.server instanceof McpServer ? params.server.server : params.server;
4243

@@ -118,6 +119,7 @@ export async function initMcpServer(params: {
118119
reqContext: {
119120
client,
120121
stainlessApiKey: params.stainlessApiKey ?? params.mcpOptions?.stainlessApiKey,
122+
upstreamClientEnvs: params.upstreamClientEnvs,
121123
},
122124
args,
123125
});

packages/mcp-server/src/types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ export type ToolCallResult = {
4545
export type McpRequestContext = {
4646
client: Isaacus;
4747
stainlessApiKey?: string | undefined;
48+
upstreamClientEnvs?: Record<string, string> | undefined;
4849
};
4950

5051
export type HandlerFunction = ({

0 commit comments

Comments
 (0)