Commit 93a486d
committed
fix(security): don't read the OAuth secret value in the orchestration debug printer (aws-samples#247 PR aws-samples#373 CodeQL high)
CodeQL flagged py/clear-text-logging-sensitive-data (HIGH) at
scripts/orchestration_debug.py:53 — the parent-meta printer derived
has_oauth via m.get('linear_oauth_secret_arn'), which READS the secret
ARN value (CodeQL's taint source) even though only 'yes'/'no' is printed.
The secret never actually reached output, but the value-read started the
taint. Fix: test KEY PRESENCE ('linear_oauth_secret_arn' in m) so the
secret string is never accessed at all — no taint source, and the printed
line provably logs only the parent issue id, repo, user id, and a
presence flag. Debug-only script (DynamoDB pretty-printer), not prod code.
Resolves the 1 high-severity CodeQL alert on PR aws-samples#373.1 parent 533316c commit 93a486d
1 file changed
Lines changed: 10 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
52 | | - | |
53 | | - | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
54 | 61 | | |
55 | 62 | | |
56 | 63 | | |
| |||
0 commit comments