[#3991] fixed more warnings

Author: Razvan Becheriu

src/lib/asiolink/testutils/test_server_unix_socket.cc

@@ -49,7 +49,7 @@ class Connection : public boost::enable_shared_from_this<Connection> {
                const std::string custom_response,
                SentResponseCallback sent_response_callback)
         : socket_(unix_socket), custom_response_(custom_response),
-          sent_response_callback_(sent_response_callback) {
+          raw_buf_(), sent_response_callback_(sent_response_callback) {
     }
 
     /// @brief Starts asynchronous read from the socket.

src/lib/dhcp/tests/opaque_data_tuple_unittest.cc

@@ -22,6 +22,10 @@ using namespace isc::util;
 namespace {
 
 struct OpaqueDataTupleLenientParsing : ::testing::Test {
+
+    /// @brief Constructor.
+    OpaqueDataTupleLenientParsing() : previous_(true) { }
+
     void SetUp() override {
         // Retain the current setting for future restoration.
         previous_ = Option::lenient_parsing_;

src/lib/dhcp/tests/option_vendor_class_unittest.cc

@@ -19,6 +19,10 @@ using namespace isc::util;
 namespace {
 
 struct OptionVendorClassLenientParsing : ::testing::Test {
+
+    /// @brief Constructor.
+    OptionVendorClassLenientParsing() : previous_(true) { }
+
     void SetUp() override {
         // Retain the current setting for future restoration.
         previous_ = Option::lenient_parsing_;

src/lib/dns/rdata.cc

@@ -333,7 +333,7 @@ Generic::toText() const {
     ostringstream oss;
 
     oss << "\\# " << impl_->data_.size() << " ";
-    oss.fill('0');
+    (void)oss.fill('0');
     oss << right << hex;
     for_each(impl_->data_.begin(), impl_->data_.end(), UnknownRdataDumper(oss));
 

src/lib/dns/tests/rdata_unittest.cc

@@ -256,7 +256,7 @@ Rdata_Unknown_Test::getLongestRdataTxt() {
     ostringstream oss;
 
     oss << "\\# " << MAX_RDLENGTH << " ";
-    oss.fill('0');
+    (void)oss.fill('0');
     oss << right << hex;
     for (unsigned i = 0; i < MAX_RDLENGTH; i++) {
         oss << setw(2) << (i & 0xff);

src/lib/log/tests/logger_manager_unittest.cc

@@ -354,7 +354,7 @@ class RegexHolder {
         const int rc = regcomp(&regex_, expr, flags);
         if (rc) {
             regfree(&regex_);
-            throw;
+            isc_throw(Exception, "Unable to create regex");
         }
     }
 

src/lib/util/buffer.h

@@ -557,7 +557,7 @@ class OutputBuffer {
     /// @param data A pointer to the data to be copied into the buffer.
     /// @param len The length of the data in bytes.
     void writeData(const void* data, size_t len) {
-        if (len == 0) {
+        if (len == 0 || data == 0) {
             return;
         }
 

src/lib/util/tests/state_model_unittest.cc

@@ -242,7 +242,7 @@ class StateModelTest : public StateModel, public testing::Test {
 
     /// @brief  Manually construct the event and state dictionaries.
     /// This allows testing without running startModel.
-    void initDictionaries() {
+    void initTestDictionaries() {
         ASSERT_NO_THROW(defineEvents());
         ASSERT_NO_THROW(verifyEvents());
         ASSERT_NO_THROW(defineStates());
@@ -509,7 +509,7 @@ TEST_F(StateModelTest, runBeforeStart) {
 /// a normal conclusion.
 TEST_F(StateModelTest, transitionWithEnd) {
     // Init dictionaries manually, normally done by startModel.
-    initDictionaries();
+    initTestDictionaries();
 
     // call transition to move from NEW_ST to DUMMY_ST with START_EVT
     EXPECT_NO_THROW(transition(DUMMY_ST, START_EVT));
@@ -534,7 +534,7 @@ TEST_F(StateModelTest, transitionWithEnd) {
 /// failed conclusion.
 TEST_F(StateModelTest, transitionWithAbort) {
     // Init dictionaries manually, normally done by startModel.
-    initDictionaries();
+    initTestDictionaries();
 
     // call transition to move from NEW_ST to DUMMY_ST with START_EVT
     EXPECT_NO_THROW(transition(DUMMY_ST, START_EVT));
@@ -559,7 +559,7 @@ TEST_F(StateModelTest, transitionWithAbort) {
 /// work properly.
 TEST_F(StateModelTest, doFlags) {
     // Init dictionaries manually, normally done by startModel.
-    initDictionaries();
+    initTestDictionaries();
 
     // Verify that "do" flags are false.
     EXPECT_FALSE(doOnEntry());
@@ -590,7 +590,7 @@ TEST_F(StateModelTest, doFlags) {
 /// the model is running but not after.
 TEST_F(StateModelTest, statusMethods) {
     // Init dictionaries manually, normally done by startModel.
-    initDictionaries();
+    initTestDictionaries();
 
     // After construction, state model is "new", all others should be false.
     EXPECT_TRUE(isModelNew());