[#3991] Added comments about cppcheck suppressions

Author: fxdupont

src/lib/asiolink/io_service_thread_pool.cc

@@ -47,6 +47,10 @@ IoServiceThreadPool::IoServiceThreadPool(IOServicePtr io_service, size_t pool_si
     }
 }
 
+// This destructor throws (when it must not) when called by a thread
+// which is not the main one (e.g. a worker thread). This can't happen
+// but static analyzers e.g. cppcheck do not know this so they complain.
+// cppcheck-suppress throwInNoexceptFunction
 IoServiceThreadPool::~IoServiceThreadPool() {
     stop();
 }

src/lib/asiolink/unix_domain_socket.cc

@@ -32,6 +32,7 @@ class UnixDomainSocketImpl : public boost::enable_shared_from_this<UnixDomainSoc
     /// @brief Destructor.
     ///
     /// Closes the socket.
+    // cppcheck-suppress throwInNoexceptFunction
     ~UnixDomainSocketImpl() {
         close();
     }

src/lib/util/thread_pool.h

@@ -49,6 +49,11 @@ struct ThreadPool {
     }
 
     /// @brief Destructor
+    ///
+    /// This destructor throws (when it must not) when called by a thread
+    /// which is not the main one (e.g. a worker thread). This can't happen
+    /// but static analyzers e.g. cppcheck do not know this so they complain.
+    // cppcheck-suppress throwInNoexceptFunction
     ~ThreadPool() {
         reset();
     }

src/lib/util/unlock_guard.h

@@ -32,6 +32,7 @@ class UnlockGuard : public boost::noncopyable {
     /// @brief Destructor.
     ///
     /// Lock mutex object on destructor.
+    // cppcheck-suppress throwInNoexceptFunction
     ~UnlockGuard() {
         lock_.lock();
     }