Commit 30d6e23
committed
fix: Remove improper effect() usage to fix runtime error
Removed effect() calls from constructors that were tracking @input properties
instead of signals, which caused 'Cannot read properties of null' errors.
Moved logic to ngOnChanges() and ngOnInit() lifecycle hooks.1 parent a099a9d commit 30d6e23
2 files changed
Lines changed: 13 additions & 14 deletions
File tree
- demo/src/app/components/playground/component-playground
- src/lib/components/perfect-select
Lines changed: 2 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
| 41 | + | |
47 | 42 | | |
48 | 43 | | |
49 | 44 | | |
| |||
Lines changed: 11 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
17 | 16 | | |
18 | 17 | | |
19 | 18 | | |
| |||
282 | 281 | | |
283 | 282 | | |
284 | 283 | | |
285 | | - | |
286 | | - | |
287 | | - | |
288 | | - | |
289 | | - | |
290 | | - | |
| 284 | + | |
291 | 285 | | |
292 | 286 | | |
293 | 287 | | |
294 | 288 | | |
295 | 289 | | |
296 | 290 | | |
297 | 291 | | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
298 | 297 | | |
299 | 298 | | |
300 | 299 | | |
| |||
319 | 318 | | |
320 | 319 | | |
321 | 320 | | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
322 | 326 | | |
323 | 327 | | |
324 | 328 | | |
| |||
0 commit comments