Skip to content

Commit 1c049ba

Browse files
ishikawa-proclaude
andcommitted
fix: resolve electron-builder signing error on GitHub Actions
- Change identity from '-' to null to skip electron-builder signing - Add CSC_FOR_PULL_REQUEST env var to ensure signing is skipped - Keep manual ad-hoc signing step after build for consistency This fixes the 'no valid identity' error during the build process. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 2ddede2 commit 1c049ba

3 files changed

Lines changed: 3 additions & 2 deletions

File tree

.github/workflows/build-and-release.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ jobs:
1818

1919
env:
2020
CSC_IDENTITY_AUTO_DISCOVERY: "false"
21+
CSC_FOR_PULL_REQUEST: "true"
2122

2223
steps:
2324
- name: Checkout code

electron-builder.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
}
3131
],
3232
"icon": "logo.png",
33-
"identity": "-",
33+
"identity": null,
3434
"hardenedRuntime": true,
3535
"gatekeeperAssess": false,
3636
"artifactName": "${productName}-${version}-${os}-${arch}.${ext}"

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "diff-viewer",
3-
"version": "0.1.14",
3+
"version": "0.1.15",
44
"description": "A rich Git diff viewer with syntax highlighting",
55
"main": "build/electron/main.js",
66
"homepage": "./",

0 commit comments

Comments
 (0)