Fixes for pybind11-stubgen errors#6896
Conversation
|
I split this from #6869 because it contains changes that actually modify the bindings a bit: Might be easier to first merge #6869 and then discuss further changes here (with more detailed explanation from me). |
|
ToGoogleDocString strips any type annotations from function signatures, so every I fixed most of these errors so now the remaining
|
|
I do not know how to fix the last two errors right now, so for now I will have to leave them and maybe fix them later. |
|
All changes can be summarized as follows:
|
|
Fixed the last remaining errors:
Now |
* It now mirrors constructor call.
|
Issues stays with me: (dmd-api) dante@dante-pc:~/PycharmProjects/dmd-api$ uv add "open3d>=0.19"
Resolved 102 packages in 1.65s
Prepared 1 package in 6m 41s
Uninstalled 1 package in 19ms
Installed 1 package in 35ms
- open3d==0.18.0
+ open3d==0.19.0
(dmd-api) dante@dante-pc:~/PycharmProjects/dmd-api$ pybind11-stubgen -o .stubs --root-suffix "" open3d
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.argoverse.Argoverse : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.base_dataset.BaseDataset : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.base_dataset.BaseDatasetSplit : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.customdataset.Custom3D : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.customdataset.Custom3DSplit : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.inference_dummy.InferenceDummySplit : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.kitti.KITTI : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.lyft.Lyft : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.matterport_objects.MatterportObjects : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.nuscenes.NuScenes : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.parislille3d.ParisLille3D : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.parislille3d.ParisLille3DSplit : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.s3dis.S3DIS : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.s3dis.S3DISSplit : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.scannet.Scannet : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.scannet.ScannetSplit : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.semantic3d.Semantic3D : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.semantic3d.Semantic3DSplit : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.semantickitti.SemanticKITTI : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.semantickitti.SemanticKITTISplit : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.shapenet.ShapeNet : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.sunrgbd.SunRGBD : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.toronto3d.Toronto3D : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.toronto3d.Toronto3DSplit : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.tumfacade.TUMFacade : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.tumfacade.TUMFacadeSplit : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.waymo.Waymo : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d.cuda.pybind.geometry.VoxelGrid.create_from_point_cloud : Invalid expression '<VoxelPoolingMode.AVG: 0>'
pybind11_stubgen - [ ERROR] In open3d.cuda.pybind.geometry.VoxelGrid.create_from_point_cloud_within_bounds : Invalid expression '<VoxelPoolingMode.AVG: 0>'
pybind11_stubgen - [ ERROR] In open3d.cuda.pybind.t.io.RealSenseSensor.init_sensor : Invalid expression 'open3d::io::RGBDSensorConfig'
pybind11_stubgen - [ ERROR] In open3d.cuda.pybind.t.io.RealSenseSensor.init_sensor : Invalid expression '<open3d.cuda.pybind.t.io.RealSenseSensorConfig object at 0x7f41f8171070>'
pybind11_stubgen - [ ERROR] In open3d.cuda.pybind.t.io.RealSenseSensor.init_sensor : Invalid expression '<open3d.cuda.pybind.t.io.RealSenseSensorConfig object at 0x7f41f8146930>'
pybind11_stubgen - [WARNING] Enum-like str representations were found with no matching mapping to the enum class location.
Use `--enum-class-locations` to specify full path to the following enum(s):
- VoxelPoolingMode
pybind11_stubgen - [WARNING] Raw C++ types/values were found in signatures extracted from docstrings.
Please check the corresponding sections of pybind11 documentation to avoid common mistakes in binding code:
- https://pybind11.readthedocs.io/en/latest/advanced/misc.html#avoiding-cpp-types-in-docstrings
- https://pybind11.readthedocs.io/en/latest/advanced/functions.html#default-arguments-revisited
(dmd-api) dante@dante-pc:~/PycharmProjects/dmd-api$ pybind11-stubgen -o ".venv/lib/python3.11/site-packages/" --root-suffix "" open3d
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.argoverse.Argoverse : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.base_dataset.BaseDataset : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.base_dataset.BaseDatasetSplit : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.customdataset.Custom3D : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.customdataset.Custom3DSplit : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.inference_dummy.InferenceDummySplit : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.kitti.KITTI : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.lyft.Lyft : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.matterport_objects.MatterportObjects : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.nuscenes.NuScenes : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.parislille3d.ParisLille3D : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.parislille3d.ParisLille3DSplit : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.s3dis.S3DIS : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.s3dis.S3DISSplit : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.scannet.Scannet : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.scannet.ScannetSplit : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.semantic3d.Semantic3D : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.semantic3d.Semantic3DSplit : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.semantickitti.SemanticKITTI : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.semantickitti.SemanticKITTISplit : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.shapenet.ShapeNet : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.sunrgbd.SunRGBD : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.toronto3d.Toronto3D : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.toronto3d.Toronto3DSplit : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.tumfacade.TUMFacade : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.tumfacade.TUMFacadeSplit : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d._ml3d.datasets.waymo.Waymo : Can't find/import '_abc._abc_data'
pybind11_stubgen - [ ERROR] In open3d.cuda.pybind.geometry.VoxelGrid.create_from_point_cloud : Invalid expression '<VoxelPoolingMode.AVG: 0>'
pybind11_stubgen - [ ERROR] In open3d.cuda.pybind.geometry.VoxelGrid.create_from_point_cloud_within_bounds : Invalid expression '<VoxelPoolingMode.AVG: 0>'
pybind11_stubgen - [ ERROR] In open3d.cuda.pybind.t.io.RealSenseSensor.init_sensor : Invalid expression 'open3d::io::RGBDSensorConfig'
pybind11_stubgen - [ ERROR] In open3d.cuda.pybind.t.io.RealSenseSensor.init_sensor : Invalid expression '<open3d.cuda.pybind.t.io.RealSenseSensorConfig object at 0x7f9aaa4d21f0>'
pybind11_stubgen - [ ERROR] In open3d.cuda.pybind.t.io.RealSenseSensor.init_sensor : Invalid expression '<open3d.cuda.pybind.t.io.RealSenseSensorConfig object at 0x7f9a55f8ba30>'
pybind11_stubgen - [WARNING] Enum-like str representations were found with no matching mapping to the enum class location.
Use `--enum-class-locations` to specify full path to the following enum(s):
- VoxelPoolingMode
pybind11_stubgen - [WARNING] Raw C++ types/values were found in signatures extracted from docstrings.
Please check the corresponding sections of pybind11 documentation to avoid common mistakes in binding code:
- https://pybind11.readthedocs.io/en/latest/advanced/misc.html#avoiding-cpp-types-in-docstrings
- https://pybind11.readthedocs.io/en/latest/advanced/functions.html#default-arguments-revisited |
|
I think the The following was already fixed in #7148, which was added after the 0.19 release: The realsense errors should be easily fixable using Open3D/cpp/pybind/t/io/sensor.cpp Lines 277 to 296 in 3550f4e I do not have time to work on this currently (life is busy right now). |
Type
Motivation and Context
This pull request is a follow up for/based on #6869 and contains more fixes for documentation and typing generation.
Related issues are #3052 and #6867.
Checklist:
python util/check_style.py --applyto apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
Typings are generated using: