Conversation
This update improves the Android camera experience by optimizing image capture, refining performance configurations, and fixing permission flow issues. **Android Changes:** - **Camera Capture:** Added `VolumeButtonCapture` to support hardware volume buttons for taking photos. - **Resolution & Quality:** Switched to `ResolutionSelector` with a 4:3 target aspect ratio and high-resolution strategy. Improved `HighPerformanceConfig` to detect high-end devices using RAM, API level, and hardware chipset. - **Image Processing:** Optimized `ImageProcessor` with a dedicated `CoroutineScope` and better memory management (aggressive bitmap recycling and temporary file cleanup). - **Concurrency:** Introduced `isCapturing` state in `CameraCaptureStateHolder` to prevent multiple simultaneous capture triggers. - **Permissions:** Refactored `RequestCameraPermission` to use `LifecycleEventEffect` for more reliable state checks on resume and improved permanent denial detection using `shouldShowRequestPermissionRationale`. - **Bug Fixes:** Fixed potential `IllegalStateException` when resolving parent directories for compressed/corrected images. Added fallback to `context.filesDir` in `FileManager`. **Common & iOS Changes:** - **UX:** Reduced `DELAY_TO_TAKE_PHOTO` from 150ms to 50ms for a more responsive feel. - **Compression:** Adjusted `CompressionLevel` thresholds and quality values for better balance. - **iOS:** Fixed a bug in `RequestCameraPermission` where dialog state wasn't reset after navigating to settings. Improved `AppLifecycleObserver` using `rememberUpdatedState`. - **Dependencies:** Added `androidx.lifecycle:lifecycle-runtime-compose` dependency. - **Version:** Updated project version to `1.0.33-alpha1`.
This update improves the Android camera experience by optimizing image capture, refining performance configurations, and fixing permission flow issues. **Android Changes:** - **Camera Capture:** Added `VolumeButtonCapture` to support hardware volume buttons for taking photos. - **Resolution & Quality:** Switched to `ResolutionSelector` with a 4:3 target aspect ratio and high-resolution strategy. Improved `HighPerformanceConfig` to detect high-end devices using RAM, API level, and hardware chipset. - **Image Processing:** Optimized `ImageProcessor` with a dedicated `CoroutineScope` and better memory management (aggressive bitmap recycling and temporary file cleanup). - **Concurrency:** Introduced `isCapturing` state in `CameraCaptureStateHolder` to prevent multiple simultaneous capture triggers. - **Permissions:** Refactored `RequestCameraPermission` to use `LifecycleEventEffect` for more reliable state checks on resume and improved permanent denial detection using `shouldShowRequestPermissionRationale`. - **Bug Fixes:** Fixed potential `IllegalStateException` when resolving parent directories for compressed/corrected images. Added fallback to `context.filesDir` in `FileManager`. **Common & iOS Changes:** - **UX:** Reduced `DELAY_TO_TAKE_PHOTO` from 150ms to 50ms for a more responsive feel. - **Compression:** Adjusted `CompressionLevel` thresholds and quality values for better balance. - **iOS:** Fixed a bug in `RequestCameraPermission` where dialog state wasn't reset after navigating to settings. Improved `AppLifecycleObserver` using `rememberUpdatedState`. - **Dependencies:** Added `androidx.lifecycle:lifecycle-runtime-compose` dependency. - **Version:** Updated project version to `1.0.33-alpha1`.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.