Conversation
The Android PreviewView was hardcoded to FILL_CENTER, which crops the 4:3 camera feed to fit tall phone viewports. The captured image, however, is saved at full 4:3 — so the confirmation screen reveals content that was not visible during framing. Expose PreviewScaleType on CameraCaptureConfig and CameraPreviewConfig so callers can opt into FIT_CENTER (letterbox the preview to match capture). Defaults to FILL_CENTER to preserve existing behavior.
Feature/preview scale type
Merge pull request #122 from ismoy/develop
This reverts commit 2304d81.
Feature/camera scale type
…ate code comments - Add `CameraScaleType` enum to control Android camera preview scaling (FILL vs FIT) - Add `confirmationImageContentScale` to `PermissionAndConfirmationConfig` for post-capture preview customization - Update documentation and changelog to reflect v1.0.41 changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Type of Change
Testing
Test configuration:
Screenshots / Screen Recording (if applicable)
Checklist
./gradlew detektand there are no new issues./gradlew test)docs/, README if needed)docs/CHANGELOG.mdunder[Unreleased]develop(notmain)Additional Notes