Conversation
fix: Android API 29 camera blank screen and improve gallery picker UX
feat: Handle picker dismissal on iOS and improve Android result handling
- Introduces Korean translations for the image crop view's title, cancel, and apply buttons. - Replaces hardcoded English strings in `CropHeaderControls` with string resources to support localization. - Adds default English string resources in `values/strings.xml`.
- Added new string resources for crop control UI elements, including zoom, rotation, and crop shape descriptions. - Implemented Korean translations for the new crop control strings. - Updated the `CropControlsPanel` to use the new string resources for labels and content descriptions, enabling localization.
This commit refactors the string resource handling to use the modern Compose multiplatform resources library (`org.jetbrains.compose.resources`). This change centralizes string management, simplifies localization, and removes the legacy `expect/actual` implementation for string resources across all platforms (Android, iOS, JVM, and JS). - **Centralized String Resources:** - Moved all string definitions from platform-specific files (`values/strings.xml` on Android, `.kt` files on other platforms) into a single `commonMain/composeResources/values/strings.xml` file. - Added Spanish (`-es`) and French (`-fr`) translations, which are now managed within the `composeResources` directory. - **Removed Legacy `expect/actual` Pattern:** - Deleted the `expect fun stringResource` declaration and its platform-specific `actual` implementations. - Removed the `StringResource` enum, as resource access is now handled by the generated `Res` class. - **Updated Resource Accessors:** - Replaced calls like `stringResource(StringResource.MY_STRING)` with the new type-safe accessor `stringResource(Res.string.my_string)`. - Updated UI components across all modules to use the new resource-loading mechanism.
This commit updates the project's build configuration to use the Gradle version catalog for managing the Compose Multiplatform plugin and its dependencies. This change improves dependency management by centralizing version and alias definitions. - Replaced the hardcoded Compose Multiplatform plugin declaration with a type-safe accessor from the version catalog (`libs.plugins.composeMultiplatform`). - Moved the `components-resources` dependency to the `libs.versions.toml` file for consistent version management.
This commit updates the project's build configuration to use the Gradle version catalog for managing the Compose Multiplatform plugin and its dependencies. This change improves dependency management by centralizing version and alias definitions. - Replaced the hardcoded Compose Multiplatform plugin declaration with a type-safe accessor from the version catalog (`libs.plugins.composeMultiplatform`). - Moved the `components-resources` dependency to the `libs.versions.toml` file for consistent version management.
This commit introduces comprehensive Korean translations for core functionalities of the image picker library. It covers permission handling, image confirmation, selection dialogs, accessibility labels, and error messages.
- **Permission Handling:** Added Korean strings for camera and gallery permission requests, denials, and guidance to open settings.
- **Image Confirmation & Selection:** Translated the confirmation dialog ("accept", "retry") and the source selection dialog ("take photo", "select from gallery").
- **Accessibility & Errors:** Provided Korean translations for accessibility descriptions (e.g., image previews) and various error messages (e.g., capture failed, permission error).
- **Existing Strings:** Integrated new strings alongside existing Korean translations for the image crop view.
This commit removes an explicit declaration for `resources.srcDir("src/commonMain/resources")` from the iOS source set in the `build.gradle.kts` file. This path is already a default resource location for Kotlin Multiplatform projects, making the explicit declaration redundant.
This commit fixes a missing resource name for the image confirmation title and adds the standard XML declaration to the string resource files. - Renamed the Korean translation string for "Do you like this image?" to `image_confirmation_title` to match its intended use. - Added the `<?xml version="1.0" encoding="utf-8"?>` declaration to both the default English and Korean `strings.xml` files for correctness.
This commit removes the `componentsResources` version alias from the `gradle/libs.versions.toml` file as it is no longer in use.
Migrate to Compose Multiplatform Resources and add Korean
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.