Skip to content

Commit 2b4314a

Browse files
committed
Additional logging for post-upload task tracking.
1 parent 5eda1bc commit 2b4314a

2 files changed

Lines changed: 17 additions & 4 deletions

File tree

app/lib/package/backend.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2590,7 +2590,7 @@ class _VersionTransactionDataAcccess {
25902590
() => taskBackend.trackPackage(
25912591
package,
25922592
updateDependents: taskUpdateDependents,
2593-
refreshVersionsCache: true,
2593+
isPostUploadTracking: true,
25942594
),
25952595
),
25962596
if (!skipExport)

app/lib/task/backend.dart

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import 'package:gcloud/storage.dart' show Bucket;
1818
import 'package:googleapis/storage/v1.dart' show DetailedApiRequestError;
1919
import 'package:indexed_blob/indexed_blob.dart'
2020
show BlobIndexReader, BlobSliceReader, HashIndex;
21-
import 'package:logging/logging.dart' show Logger;
21+
import 'package:logging/logging.dart' show Level, Logger;
2222
import 'package:meta/meta.dart';
2323
import 'package:pana/models.dart' show Summary;
2424
import 'package:pool/pool.dart' show Pool;
@@ -369,17 +369,20 @@ class TaskBackend {
369369
Future<void> trackPackage(
370370
String packageName, {
371371
bool updateDependents = false,
372-
bool refreshVersionsCache = false,
372+
bool isPostUploadTracking = false,
373373
}) async {
374374
var lastVersionCreated = initialTimestamp;
375375
String? latestVersion;
376376
late package_api.PackageData data;
377377
try {
378378
data = await packageBackend.listVersionsCached(
379379
packageName,
380-
refreshVersionsCache: refreshVersionsCache,
380+
refreshVersionsCache: isPostUploadTracking,
381381
);
382382
} on NotFoundException catch (_) {
383+
_log.warning(
384+
'trackPackage could not list versions for package "$packageName"',
385+
);
383386
// If package is not visible, we should remove it!
384387
for (final rv in acceptedRuntimeVersions) {
385388
await _database.withRetry(
@@ -391,6 +394,7 @@ class TaskBackend {
391394
final versions = _versionsToTrack(
392395
data,
393396
).map((v) => v.canonicalizedVersion).toList();
397+
394398
final changed = await _database.transactWithRetry((db) async {
395399
final task = await db.taskLookupOrNull(packageName);
396400
latestVersion = data.latest.version;
@@ -446,6 +450,15 @@ class TaskBackend {
446450
.isEmpty,
447451
);
448452

453+
if (isPostUploadTracking) {
454+
final level = untrackedVersions.isEmpty ? Level.WARNING : Level.INFO;
455+
_log.log(
456+
level,
457+
'Post-upload task tracking found ${untrackedVersions.length} untracked and '
458+
'${deselectedVersions.length} deselected versions for package "$packageName".',
459+
);
460+
}
461+
449462
// Stop transaction, if there is no changes to be made!
450463
if (untrackedVersions.isEmpty &&
451464
deselectedVersions.isEmpty &&

0 commit comments

Comments
 (0)