Fix task queries + add indexes. (dart-lang#9474)

Author: isoos

app/lib/database/migration.g.dart

@@ -5,6 +5,12 @@
 part of 'schema.dart';
 
 @PrimaryKey(['runtimeVersion', 'package'])
+@Index(name: 'currentFinished', fields: ['runtimeVersion', 'finished'])
+@Index(name: 'currentPendingAt', fields: ['runtimeVersion', 'pendingAt'])
+@Index(
+  name: 'currentDependencyChanged',
+  fields: ['runtimeVersion', 'lastDependencyChanged'],
+)
 abstract final class Task extends Row {
   /// Runtime version this [Task] belongs to.
   String get runtimeVersion;
@@ -32,6 +38,7 @@ abstract final class Task extends Row {
   onDelete: .cascade,
   onUpdate: .cascade,
 )
+@Index(name: 'currentDependency', fields: ['runtimeVersion', 'dependency'])
 abstract final class TaskDependency extends Row {
   String get runtimeVersion;
   String get package;

app/lib/database/schema.g.dart

@@ -303,7 +303,11 @@ class TaskBackend {
       // list tasks with dependency updated >= since
       final list = await _database.withRetry(
         (db) => db.tasks
-            .where((t) => t.lastDependencyChanged >= since.asExpr)
+            .where(
+              (t) =>
+                  t.runtimeVersion.equalsValue(runtimeVersion) &
+                  (t.lastDependencyChanged >= since.asExpr),
+            )
             .select((t) => (t.package, t.lastDependencyChanged))
             .stream()
             .map((e) => (name: e.$1, updated: e.$2))
@@ -1347,7 +1351,11 @@ extension TaskDatabaseExt on Database<PrimarySchema> {
     DateTime since,
   ) {
     return tasks
-        .where((task) => task.finished >= since.asExpr)
+        .where(
+          (task) =>
+              task.runtimeVersion.equalsValue(runtimeVersion) &
+              (task.finished >= since.asExpr),
+        )
         .orderBy((task) => [(task.finished, Order.descending)])
         .select((task) => (task.package, task.finished))
         .stream()

app/lib/database/schema.task.dart

@@ -0,0 +1,11 @@
+-- Create index "task_dependencies_idx_current_dependency" to table: "task_dependencies"
+CREATE INDEX "task_dependencies_idx_current_dependency" ON "task_dependencies" ("runtime_version", "dependency");
+
+-- Create index "tasks_idx_current_dependency_changed" to table: "tasks"
+CREATE INDEX "tasks_idx_current_dependency_changed" ON "tasks" ("runtime_version", "last_dependency_changed");
+
+-- Create index "tasks_idx_current_finished" to table: "tasks"
+CREATE INDEX "tasks_idx_current_finished" ON "tasks" ("runtime_version", "finished");
+
+-- Create index "tasks_idx_current_pending_at" to table: "tasks"
+CREATE INDEX "tasks_idx_current_pending_at" ON "tasks" ("runtime_version", "pending_at");

app/lib/task/backend.dart

@@ -1 +1,2 @@
 edfd3d977ef308147b29a609c48f3913608e4888d073479995bdb8b37a643806  000001_task.sql
+2bc197ecebfa5cc1511ec252141e177880e824b4e939e76e2128106a256ab791  000002_task_index.sql

app/migrations/000002_task_index.sql

@@ -44,7 +44,7 @@ dependencies:
   shelf_router: ^1.1.0
   stack_trace: ^1.10.0
   stream_transform: ^2.0.0
-  typed_sql: ^0.1.12
+  typed_sql: ^0.1.13
   watcher: ^1.0.0
   yaml: ^3.1.0
   # pana version to be pinned

app/migrations/sha256sum.txt

@@ -925,10 +925,10 @@ packages:
     dependency: transitive
     description:
       name: typed_sql
-      sha256: "5686003f20defaf5dc01b308bdff63837ee6129e450b9ea9fab507db96f40600"
+      sha256: "9f6cbb8313c35f645da9d593bef78c6e5e225452a5c0e53252840fccf70a4779"
       url: "https://pub.dev"
     source: hosted
-    version: "0.1.12"
+    version: "0.1.13"
   ulid:
     dependency: transitive
     description: