Skip to content

Add Natural Transition Orbital calculation and processing#272

Open
hughf2468 wants to merge 16 commits into
ispg-group:mainfrom
AaronH-sys:prcommits
Open

Add Natural Transition Orbital calculation and processing#272
hughf2468 wants to merge 16 commits into
ispg-group:mainfrom
AaronH-sys:prcommits

Conversation

@hughf2468
Copy link
Copy Markdown

Added steps to calculate NTOs when requested, convert to relevant ".cube" files, and compress these files.

Implemented requested changes and added aiida-shell and cubehandler as dependencies in setup.cfg.

@hughf2468 hughf2468 marked this pull request as ready for review April 27, 2026 23:30
@danielhollas danielhollas changed the title Added Natural Transition Orbital calculation and processing 2. Add Natural Transition Orbital calculation and processing Apr 28, 2026
@danielhollas
Copy link
Copy Markdown
Member

Thanks @hughf2468! Great the pre-commit and tests are passing!

Did you test that cubehandler works with python 3.9? If so, can you also open a PR from your cubehandler atmospec branch against the original repo? (will be nice to get credit for all your work there as well!)

@hughf2468
Copy link
Copy Markdown
Author

Thanks @hughf2468! Great the pre-commit and tests are passing!

Did you test that cubehandler works with python 3.9? If so, can you also open a PR from your cubehandler atmospec branch against the original repo? (will be nice to get credit for all your work there as well!)

No worries @danielhollas, I haven't tested cubehandler extensively under Python 3.9, I know that the functions used by the above code work as expected, however I am not sure if there is any other functionality that might be problematic. Is it worth opening a PR anyway to bring it to their attention? Thanks.

@danielhollas
Copy link
Copy Markdown
Member

Is it worth opening a PR anyway to bring it to their attention? Thanks.

Yes please! As long as you explain what you tested I think it's fine to you open the PR! (I can then help to shepherd it forward, I don't want to put extra work on you)

@hughf2468
Copy link
Copy Markdown
Author

Is it worth opening a PR anyway to bring it to their attention? Thanks.

Yes please! As long as you explain what you tested I think it's fine to you open the PR! (I can then help to shepherd it forward, I don't want to put extra work on you)

No problem. I've opened a PR if you'd like to have a look. Thanks

Comment thread setup.cfg Outdated
Comment thread setup.cfg Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants