fortitude: enable unchecked-stat rule (#46)

Ignoring IO errors is BAD!

Author: danielhollas

fortitude.toml

@@ -3,7 +3,6 @@ ignore = [
   "implicit-external-procedures", # requires Fortran 2018
   "star-kind", # don't use integer*4 et al
   "literal-kind",
-  "unchecked-stat",  # TODO: Fix this!
 ]
 line-length = 132
 show-fixes = true

src/modules/RestartModule.f90

@@ -700,51 +700,37 @@ subroutine WriteElecStruc(ES, nfile_in)
 3     format(10(1x, es15.8))
 
       write (nf, *) '# Orbitals'
-      write (nf, 3, iostat=ierr) ES%OldOrbitals
+      write (nf, 3) ES%OldOrbitals
       write (nf, *) '# CI vectors'
-      write (nf, 3, iostat=ierr) ES%OldCIVecs
+      write (nf, 3) ES%OldCIVecs
       write (nf, *) '# Overlap matrix'
-      write (nf, 3, iostat=ierr) ES%OverlapMatrix
+      write (nf, 3) ES%OverlapMatrix
       write (nf, *) '# TC Blob'
-      write (nf, 3, iostat=ierr) ES%OldBlob
+      write (nf, 3) ES%OldBlob
       write (nf, *) '# MSPT2 Coeffs'
-      write (nf, 3, iostat=ierr) ES%OldMSPT2C
+      write (nf, 3) ES%OldMSPT2C
       write (nf, *) '# Electronic Phases'
-      write (nf, *, iostat=ierr) ES%ElecPhase
-
-      return
+      write (nf, *) ES%ElecPhase
    end subroutine WriteElecStruc
 
-! - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-   subroutine ReadElecStruc(ES, nfile_in)
-! - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
+   subroutine ReadElecStruc(ES, nf)
       type(T_ElecStruc), intent(inout) :: ES
-      integer(kind=DefInt), optional :: nfile_in
-
-      integer(kind=DefInt) :: nf ! unit number to write to
-! WTF: We shouldn't just blidly ignore all errors!
-      integer(kind=DefInt) :: ierr ! catch errors that may be thrown
-
-! set which file we are writing to
-      nf = 5
-      if (present(nfile_in)) nf = nfile_in
+      integer(kind=DefInt), intent(in) :: nf
 
 3     format(10(1x, es15.8))
 
       read (nf, *)
-      read (nf, 3, iostat=ierr) ES%OldOrbitals
+      read (nf, 3) ES%OldOrbitals
       read (nf, *)
-      read (nf, 3, iostat=ierr) ES%OldCIVecs
+      read (nf, 3) ES%OldCIVecs
       read (nf, *)
-      read (nf, 3, iostat=ierr) ES%OverlapMatrix
+      read (nf, 3) ES%OverlapMatrix
       read (nf, *)
-      read (nf, 3, iostat=ierr) ES%OldBlob
+      read (nf, 3) ES%OldBlob
       read (nf, *)
-      read (nf, 3, iostat=ierr) ES%OldMSPT2C
+      read (nf, 3) ES%OldMSPT2C
       read (nf, *)
-!DEBUG - changed v from read(nf,3,iostat=ierr)
-      read (nf, *, iostat=ierr) ES%ElecPhase
-      return
+      read (nf, *) ES%ElecPhase
    end subroutine ReadElecStruc
 
 ! * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *

src/modules/SamplingModule.f90

@@ -1082,7 +1082,7 @@ subroutine read_frequencies(natoms, mass, nfreq, freq, Umat)
 
       case ('HESS')
          filein = trim(FMSWorkingDir)//'Hessian.dat'
-         open (newunit=ifunit, file=filein, status='old', action='read', iostat=ios)
+         open (newunit=ifunit, file=filein, status='old', action='read')
          write (fmiOut, *) 'Using Hessian.dat to find normal mode frequencies'
          read (IFUnit, *, end=999) natomsin
          if (natomsin /= natoms) then