fortitude: Enable nonportable-shortcircuit-inquiry rule (#45)

(from fortitude's explanation)
Unlike many other languages, the Fortran standard doesn't mandate (or prohibit)
short-circuiting in logical expressions, so different compilers have different
behaviour when it comes to evaluating such expressions. This is commonly encountered
when using present() with an optional dummy argument and checking its value in the
same expression. Without short-circuiting, this can lead to segmentation faults when
the expression is evaluated if the argument isn't present.

Author: danielhollas

fortitude.toml

@@ -4,7 +4,6 @@ ignore = [
   "star-kind", # don't use integer*4 et al
   "literal-kind",
   "unchecked-stat",  # TODO: Fix this!
-  "nonportable-shortcircuit-inquiry",  # TODO: Fix this!
 ]
 line-length = 132
 show-fixes = true

src/modules/BundleIOModule.f90

@@ -271,8 +271,10 @@ subroutine FMS_WriteFSOME(T1, T2, Tc, filename, firsttime)
 
       ! 2. work out if we are opening a new file
       file_exists = .true.
-      if (present(firsttime) .and. firsttime) then
-         inquire (file=file_name, exist=file_exists)
+      if (present(firsttime)) then
+         if (firsttime) then
+            inquire (file=file_name, exist=file_exists)
+         end if
       end if
 
       ! 3. open the file

src/modules/TrajectoryIOModule.f90

@@ -266,8 +266,10 @@ subroutine FMS_WriteFAngle(T, file_name, NAngles, iAngle, first_time)
       long_file_name = trim(FMSWorkingDir)//file_name
 
       file_existed = .true.
-      if (present(first_time) .and. first_time) then
-         inquire (file=long_file_name, exist=file_existed)
+      if (present(first_time)) then
+         if (first_time) then
+            inquire (file=long_file_name, exist=file_existed)
+         end if
       end if
 
       if (.not. file_existed) then
@@ -684,8 +686,10 @@ subroutine FMS_WriteFDistance(T, file_name, NBonds, iBond, first_time)
       long_file_name = trim(FMSWorkingDir)//file_name
 
       file_existed = .true.
-      if (present(first_time) .and. first_time) then
-         inquire (file=long_file_name, exist=file_existed)
+      if (present(first_time)) then
+         if (first_time) then
+            inquire (file=long_file_name, exist=file_existed)
+         end if
       end if
 
       if (.not. file_existed) then
@@ -778,8 +782,10 @@ subroutine FMS_WriteFMM(T, file_name, first_time)
       long_file_name = trim(FMSWorkingDir)//file_name
 
       file_existed = .true.
-      if (present(first_time) .and. first_time) then
-         inquire (file=long_file_name, exist=file_existed)
+      if (present(first_time)) then
+         if (first_time) then
+            inquire (file=long_file_name, exist=file_existed)
+         end if
       end if
 
       if (.not. file_existed) then
@@ -838,8 +844,10 @@ subroutine FMS_WriteFPyram(T, file_name, NPyrams, IPyram, first_time)
       long_file_name = trim(FMSWorkingDir)//file_name
 
       file_existed = .true.
-      if (present(first_time) .and. first_time) then
-         inquire (file=long_file_name, exist=file_existed)
+      if (present(first_time)) then
+         if (first_time) then
+            inquire (file=long_file_name, exist=file_existed)
+         end if
       end if
 
 !     create column labels