Skip to content

Support aocc and nvfortran compilers#44

Merged
danielhollas merged 27 commits into
mainfrom
issue-39-workaround
Jul 8, 2026
Merged

Support aocc and nvfortran compilers#44
danielhollas merged 27 commits into
mainfrom
issue-39-workaround

Conversation

@danielhollas

@danielhollas danielhollas commented May 19, 2026

Copy link
Copy Markdown
Member

(PR opened on behalf of @kevinstratford, as discussed in #39)

This PR makes OpenFMS compatible with nvfortran and aocc compilers. This required some workarounds due to compiler bugs, but also fixing issues in the RestartModule, where we were writing unallocated arrays! (I am very surprised the other compilers were fined with this).

Closes #39.

@codecov-commenter

codecov-commenter commented May 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 25.00000% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.45%. Comparing base (2756ddc) to head (f021331).

Files with missing lines Patch % Lines
src/modules/TrajectoryIOModule.f90 32.50% 27 Missing ⚠️
src/modules/RestartModule.f90 0.00% 8 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   55.13%   62.45%   +7.31%     
==========================================
  Files          42       42              
  Lines        6170     7519    +1349     
  Branches      832      835       +3     
==========================================
+ Hits         3402     4696    +1294     
- Misses       2414     2574     +160     
+ Partials      354      249     -105     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danielhollas
danielhollas force-pushed the issue-39-workaround branch from facf17f to b9c85e4 Compare May 19, 2026 12:38
@danielhollas
danielhollas force-pushed the issue-39-workaround branch from 34adb30 to e190db9 Compare May 19, 2026 14:56
@danielhollas
danielhollas force-pushed the issue-39-workaround branch from 14d3369 to 54fabf2 Compare July 7, 2026 15:02
@danielhollas
danielhollas marked this pull request as ready for review July 7, 2026 18:37
@danielhollas danielhollas changed the title Avoid problematic array constructors Support aocc and nvfortran compilers Jul 7, 2026
@danielhollas

Copy link
Copy Markdown
Member Author

So the CI is finally green, including the aocc and nvfortran jobs.
@kevinstratford in case you want to have a look.

(I still need to do a bit of manual testing since not all the codepaths modified here are covered by tests, but otherwise this is good to go).

Notably, earlier versions of nvfortran (e.g. 26.1) fails to compile the unit tests, but the latest version (26.5 works) so I won't bother implementing the workaround.

@kevinstratford

Copy link
Copy Markdown
Contributor

Restricting myself to the Fortran. A couple of extra bits of commented-out code have appeared. May want to try to remove.

Otherwise, ok!

@danielhollas

Copy link
Copy Markdown
Member Author

Thanks for taking a look. I'll keep those bits around since we might need them soon, and if not I am going to do a larger cleanup of commented out code separately in one swoop.

@danielhollas
danielhollas merged commit a1d7129 into main Jul 8, 2026
14 checks passed
@danielhollas
danielhollas deleted the issue-39-workaround branch July 8, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compiler issues

3 participants