Separated Stochastic Selection - Clean version#58
Merged
Conversation
- works the same way as (WiP) Separated Stochastic Selection, but: - only changes in SelectionModule - commented out parts removed - kept only those commented out print statements that are usefull - SSGAIMS test will follow
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
==========================================
- Coverage 53.68% 52.71% -0.97%
==========================================
Files 41 41
Lines 6058 6175 +117
Branches 825 840 +15
==========================================
+ Hits 3252 3255 +3
- Misses 2449 2562 +113
- Partials 357 358 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
danielhollas
approved these changes
Jun 5, 2026
danielhollas
left a comment
danielhollas
left a comment
Member
There was a problem hiding this comment.
This looks great, congrats!
As we discussed in person, let's get this merged, and once I am back we can go through the code in more detail and double-check everything together.
(I ran prek locally and fixed the formatting, I guess you forgot to pull the merge commit fr om #28 before copying the file)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SelectionModule