Fix onedrive upload issue

add open browser scripts for all platforms
updates for launcher apps
update libraries

Author: ispysoftware

src/SIPSorcery.csproj

@@ -1,5 +1,4 @@
 <Project Sdk="Microsoft.NET.Sdk">
-
   <ItemGroup>
     <Compile Remove="net\RTSP\RTSPClient.cs" />
     <Compile Remove="net\RTSP\RTSPConnection.cs" />
@@ -36,12 +35,12 @@
   </ItemGroup>
 
   <PropertyGroup>
-    <TargetFrameworks>netstandard2.0;netstandard2.1;netcoreapp3.1;net462;net5.0;net6.0;net8.0</TargetFrameworks>
+    <TargetFrameworks>net9.0</TargetFrameworks>
     <LangVersion>12.0</LangVersion>
     <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>
     <NoWarn>$(NoWarn);SYSLIB0050</NoWarn>
-    <TreatWarningsAsErrors>True</TreatWarningsAsErrors>
-    <GenerateDocumentationFile>true</GenerateDocumentationFile>
+    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
+    <GenerateDocumentationFile>false</GenerateDocumentationFile>
     <!-- Disable warning for missing XML doc comments. -->
     <NoWarn>$(NoWarn);CS1591;CS1573;CS1587</NoWarn>
     <Authors>Aaron Clauson, Christophe Irles, Rafael Soares &amp; Contributors</Authors>

src/app/Media/Sources/VideoTestPatternSource.cs

@@ -95,7 +95,7 @@ public VideoTestPatternSource(IVideoEncoder encoder = null)
             else
             {
                 _testI420Buffer = new byte[TEST_PATTERN_WIDTH * TEST_PATTERN_HEIGHT * 3 / 2];
-                testPatternStm.Read(_testI420Buffer, 0, _testI420Buffer.Length);
+                testPatternStm.ReadExactly(_testI420Buffer, 0, _testI420Buffer.Length);
                 testPatternStm.Close();
                 _sendTestPatternTimer = new Timer(GenerateTestPattern, null, Timeout.Infinite, Timeout.Infinite);
                 _frameSpacing = 1000 / DEFAULT_FRAMES_PER_SECOND;

src/core/SIPTransportConfig.cs

@@ -119,22 +119,31 @@ public static List<SIPChannel> ParseSIPChannelsNode(XmlNode sipChannelsNode, int
             return sipChannels;
         }
 
-        private static X509Certificate2 LoadCertificate(string certificateType, string certifcateLocation, string certKeyPassword)
+        private static X509Certificate2 LoadCertificate(string certificateType, string certificateLocation, string certKeyPassword)
         {
             try
             {
-
                 if (certificateType == "file")
                 {
-                    var serverCertificate = new X509Certificate2(certifcateLocation, certKeyPassword);
-                    //DisplayCertificateChain(m_serverCertificate);
+                    X509Certificate2 serverCertificate;
+
+                    if (!string.IsNullOrEmpty(certKeyPassword))
+                    {
+                        serverCertificate = X509CertificateLoader.LoadPkcs12FromFile(certificateLocation, certKeyPassword);
+                    }
+                    else
+                    {
+                        serverCertificate = X509CertificateLoader.LoadCertificateFromFile(certificateLocation);
+                    }
+
+                    //DisplayCertificateChain(serverCertificate);
                     var verifyCert = serverCertificate.Verify();
                     logger.LogDebug("Server Certificate loaded from file, Subject={Subject}, valid={Valid}.", serverCertificate.Subject, verifyCert);
                     return serverCertificate;
                 }
 
                 var store = (certificateType == "machinestore") ? StoreLocation.LocalMachine : StoreLocation.CurrentUser;
-                return Crypto.LoadCertificate(store, certifcateLocation, true);
+                return Crypto.LoadCertificate(store, certificateLocation, true);
             }
             catch (Exception excp)
             {

src/net/DtlsSrtp/DtlsUtils.cs

@@ -424,20 +424,21 @@ public static X509Certificate2 ConvertBouncyCert(Org.BouncyCastle.X509.X509Certi
         {
             Pkcs12Store pkcs12Store = new Pkcs12StoreBuilder().Build();
             var certEntry = new X509CertificateEntry(bouncyCert);
-
             pkcs12Store.SetCertificateEntry(bouncyCert.SerialNumber.ToString(), certEntry);
             pkcs12Store.SetKeyEntry(bouncyCert.SerialNumber.ToString(),
                 new AsymmetricKeyEntry(keyPair.Private), new[] { certEntry });
 
             X509Certificate2 keyedCert;
-
             using (MemoryStream pfxStream = new MemoryStream())
             {
                 pkcs12Store.Save(pfxStream, new char[] { }, new SecureRandom());
                 pfxStream.Seek(0, SeekOrigin.Begin);
-                keyedCert = new X509Certificate2(pfxStream.ToArray(), string.Empty, X509KeyStorageFlags.Exportable);
-            }
 
+                keyedCert = X509CertificateLoader.LoadPkcs12(
+                    pfxStream.ToArray(),
+                    string.Empty,
+                    X509KeyStorageFlags.Exportable);
+            }
             return keyedCert;
         }
 

src/sys/Crypto/Crypto.cs

@@ -269,7 +269,7 @@ public static string GetHash(string filepath)
 
             // Buffer to read in plain text blocks.
             byte[] fileBuffer = new byte[fileStream.Length];
-            fileStream.Read(fileBuffer, 0, (int)fileStream.Length);
+            fileStream.ReadExactly(fileBuffer, 0, (int)fileStream.Length);
             fileStream.Close();
 
             byte[] overallHash = shaM.ComputeHash(fileBuffer);

src/sys/JsonParser.cs

@@ -18,6 +18,7 @@
 using System.Collections;
 using System.Collections.Generic;
 using System.Reflection;
+using System.Runtime.CompilerServices;
 using System.Runtime.Serialization;
 using System.Text;
 
@@ -348,7 +349,7 @@ static object ParseObject(Type type, string json)
         {
             // For .net8 this call needs to change to: RuntimeHelpers.GetUninitializedObject(type);
 
-            object instance = FormatterServices.GetUninitializedObject(type);
+            object instance = RuntimeHelpers.GetUninitializedObject(type);
 
             //The list is split into key/value pairs only, this means the split must be divisible by 2 to be valid JSON
             List<string> elems = Split(json);
@@ -386,4 +387,4 @@ static object ParseObject(Type type, string json)
             return instance;
         }
     }
-}
+}