Track Responsive-Design carousel resize events#57
Open
issackjohn wants to merge 1 commit into
Open
Conversation
a286c76 to
414734a
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds lightweight instrumentation to the benchmark runner to observe ResizeObserver-driven width changes on a specific element (the Responsive-Design recipe carousel) during iframe width-change workload steps, surfacing missing ResizeObserver delivery via browser warnings without changing the step boundaries.
Changes:
- Added a generic
PageElement.observeResizeEvents()helper to count delivered width changes and allow explicit disconnect. - Updated the Responsive-Design
ReduceWidthIn5Steps/IncreaseWidthIn5Stepssteps to observe.carouselandconsole.warnif no resize events were delivered.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| resources/benchmark-runner.mjs | Adds PageElement.observeResizeEvents() to track ResizeObserver deliveries and expose a disconnectable counter. |
| experimental/tests.mjs | Uses the new helper in Responsive-Design width-change steps and warns when no carousel resize events are observed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
03f3e78 to
06b5ab5
Compare
116434a to
564579a
Compare
564579a to
fbf374f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tracks the Responsive-Design recipe carousel's
ResizeObserveractivity during the two iframe width-change steps.PageElement.observeResizeEvents()to count distinct content-box width changes.ReduceWidthIn5StepsandIncreaseWidthIn5Stepson the same.carouselelement observed by the component.Motivation
This follows up on the upstream review request to make carousel resize activity visible for cross-browser comparison while providing strict tests for the deterministic counting behavior.
Implementation details
contentBoxSize, withcontentRect.widthas the compatibility fallback.Validation
Related to #54.