Skip to content

fix(perf): Improve performance by converting patterns to regexp only once #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lo1tuma wants to merge 1 commit into from
Closed

fix(perf): Improve performance by converting patterns to regexp only once #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ const { minimatch } = require('minimatch');
const { defaults } = require('@istanbuljs/schema');
const isOutsideDir = require('./is-outside-dir');

const minimatchOptionsAllowingLeadingDot = { dot: true };
function patternToRegExp(pattern) {
return minimatch.makeRe(pattern, minimatchOptionsAllowingLeadingDot);
}

class TestExclude {
constructor(opts = {}) {
Object.assign(
Expand Down Expand Up @@ -50,6 +55,13 @@ class TestExclude {
this.exclude = prepGlobPatterns([].concat(this.exclude));

this.handleNegation();
this.convertAllPatternsToRegexp();
}

convertAllPatternsToRegexp() {
this.includeRegexpPatterns = this.include === false ? [] : this.include.map(patternToRegExp);
this.excludeRegExpPatterns = this.exclude.map(patternToRegExp);
this.excludeNegatedRegexpPatterns = this.excludeNegated.map(patternToRegExp);
}

/* handle the special case of negative globs
Expand Down Expand Up @@ -94,11 +106,10 @@ class TestExclude {
pathToCheck = relFile.replace(/^\.[\\/]/, ''); // remove leading './' or '.\'.
}

const dot = { dot: true };
const matches = pattern => minimatch(pathToCheck, pattern, dot);
const matches = pattern => pattern.test(pathToCheck);
return (
(!this.include || this.include.some(matches)) &&
(!this.exclude.some(matches) || this.excludeNegated.some(matches))
(!this.include || this.includeRegexpPatterns.some(matches)) &&
(!this.excludeRegExpPatterns.some(matches) || this.excludeNegatedRegexpPatterns.some(matches))
);
}

Expand Down
Loading