Feature: Fieldignorerules#1912
Closed
nrfox wants to merge 2 commits into
Closed
Conversation
this is a cleaner API around ignoring certain fields in watches and when installing charts, through a PostRender func. The goal is to eventually expose this API to the user, but for now it'll just help to keep track of our default ignores that we have implemented to fix specific bugs. Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Removes the "Untyped" variants of FieldIgnoreRules in favor of a passing `Unstructured` as the specific type for generic rules coming from either helm manifest or user input. Signed-off-by: Nick Fox <nfox@redhat.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1912 +/- ##
===========================================
+ Coverage 69.52% 81.06% +11.54%
===========================================
Files 46 53 +7
Lines 2838 2715 -123
===========================================
+ Hits 1973 2201 +228
+ Misses 697 387 -310
+ Partials 168 127 -41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Closing this as I can just push to the fork/branch to update the original PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This is #1708 with an additional commit on top that changes the Typing a bit. The additional commit mostly removes boilerplate converting to/from "Untyped" and adds additional unit tests for unstructured objects. You can see the diff here: https://github.com/dgn/sail-operator/compare/fieldignorerules...nrfox:sail-operator:fieldignorerules?expand=1
Which issue(s) this PR fixes:
Fixes #430 and #1148
Related Issue/PR #1708
Additional information: