Skip to content

[WIP] Add monitoring controller for COO (Cluster Observability Operator)#1959

Draft
mayleighnmyers wants to merge 7 commits into
istio-ecosystem:mainfrom
mayleighnmyers:feature/coo-monitoring-controller
Draft

[WIP] Add monitoring controller for COO (Cluster Observability Operator)#1959
mayleighnmyers wants to merge 7 commits into
istio-ecosystem:mainfrom
mayleighnmyers:feature/coo-monitoring-controller

Conversation

@mayleighnmyers
Copy link
Copy Markdown

Implements a monitoring controller that creates ServiceMonitor and PodMonitor resources for IstioRevision objects. Key features:

  • Uses monitoring.rhobs/v1 API group for COO compatibility
  • Adds 'monitored-by: coo-prometheus' label for COO discovery
  • Creates ServiceMonitor (default-istiod) for istiod metrics
  • Creates PodMonitor (default-proxies) for istio-proxy metrics
  • Sets proper owner references for automatic cleanup

Relates to: OSSM-13585

What type of PR is this?

  • Enhancement / New Feature
  • Bug Fix
  • Refactor
  • Optimization
  • Test
  • Documentation Update

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Related Issue/PR #

Additional information:

Implements a monitoring controller that creates ServiceMonitor and PodMonitor
resources for IstioRevision objects. Key features:

- Uses monitoring.rhobs/v1 API group for COO compatibility
- Adds 'monitored-by: coo-prometheus' label for COO discovery
- Creates ServiceMonitor (default-istiod) for istiod metrics
- Creates PodMonitor (default-proxies) for istio-proxy metrics
- Sets proper owner references for automatic cleanup

Relates to: OSSM-13585

Signed-off-by: Mayleigh Tjapkes <mamyers@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented May 18, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

@istio-testing
Copy link
Copy Markdown
Collaborator

Hi @mayleighnmyers. Thanks for your PR.

I'm waiting for a istio-ecosystem or istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@istio-testing
Copy link
Copy Markdown
Collaborator

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mayleighnmyers and others added 2 commits May 26, 2026 15:05
Add ClusterRole permissions for ServiceMonitor and PodMonitor resources
for both monitoring.coreos.com and monitoring.rhobs API groups to allow
the monitoring controller to create and manage these resources.

Signed-off-by: Mayleigh Tjapkes <mamyers@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@nrfox
Copy link
Copy Markdown
Contributor

nrfox commented May 28, 2026

Hi @mayleighnmyers,

How would users control this if they wanted to opt in or out? What will the API be for this? You can either open an issue and we can discuss it there or better yet create a SEP for this. We need to discuss how this will integrate with the operator before we can move forward with this.

@mayleighnmyers
Copy link
Copy Markdown
Author

Hi @mayleighnmyers,

How would users control this if they wanted to opt in or out? What will the API be for this? You can either open an issue and we can discuss it there or better yet create a SEP for this. We need to discuss how this will integrate with the operator before we can move forward with this.

So this is still in progress. Good call for the opt in/out. Something we can consider is adding a field either in the Istio CR or the istioRevision CR to allow users to opt in since right now it is currently always enabled. Yuanlin and I will be talking about this more in some future meeting when we have all ducks in a row. :)

@mayleighnmyers mayleighnmyers changed the title Add monitoring controller for COO (Cluster Observability Operator) [WIP] Add monitoring controller for COO (Cluster Observability Operator) May 28, 2026
yxun and others added 2 commits June 1, 2026 15:36
Signed-off-by: Yuanlin Xu <yuanlin.xu@redhat.com>
Add draft SEP for observability integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants