[WIP] Add monitoring controller for COO (Cluster Observability Operator)#1959
[WIP] Add monitoring controller for COO (Cluster Observability Operator)#1959mayleighnmyers wants to merge 7 commits into
Conversation
Implements a monitoring controller that creates ServiceMonitor and PodMonitor resources for IstioRevision objects. Key features: - Uses monitoring.rhobs/v1 API group for COO compatibility - Adds 'monitored-by: coo-prometheus' label for COO discovery - Creates ServiceMonitor (default-istiod) for istiod metrics - Creates PodMonitor (default-proxies) for istio-proxy metrics - Sets proper owner references for automatic cleanup Relates to: OSSM-13585 Signed-off-by: Mayleigh Tjapkes <mamyers@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
Hi @mayleighnmyers. Thanks for your PR. I'm waiting for a istio-ecosystem or istio member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Add ClusterRole permissions for ServiceMonitor and PodMonitor resources for both monitoring.coreos.com and monitoring.rhobs API groups to allow the monitoring controller to create and manage these resources. Signed-off-by: Mayleigh Tjapkes <mamyers@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
Hi @mayleighnmyers, How would users control this if they wanted to opt in or out? What will the API be for this? You can either open an issue and we can discuss it there or better yet create a SEP for this. We need to discuss how this will integrate with the operator before we can move forward with this. |
So this is still in progress. Good call for the opt in/out. Something we can consider is adding a field either in the Istio CR or the istioRevision CR to allow users to opt in since right now it is currently always enabled. Yuanlin and I will be talking about this more in some future meeting when we have all ducks in a row. :) |
Signed-off-by: Yuanlin Xu <yuanlin.xu@redhat.com>
Add draft SEP for observability integration
Implements a monitoring controller that creates ServiceMonitor and PodMonitor resources for IstioRevision objects. Key features:
Relates to: OSSM-13585
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Related Issue/PR #
Additional information: