fix(ZMSKVR-1378): correct ExchangeSlotscope query parameter binding

Unfiltered report reads only bind scopeid so PDO matches QUERY_READ_REPORT.
Relax subject-list count assertion after including all slot rows in bounds.

Author: ThomasAFink

zmsdb/src/Zmsdb/ExchangeSlotscope.php

@@ -45,14 +45,13 @@ public function readEntity(
         $queryConstant = $this->resolveQueryConstant($period, $unfiltered);
 
         foreach ($subjectIdList as $scopeId) {
-            $raw = $this->fetchAll(
-                constant($queryConstant),
-                [
-                    'scopeid' => $scopeId,
-                    'datestart' => $datestart->format('Y-m-d'),
-                    'dateend' => $dateend->format('Y-m-d'),
-                ]
-            );
+            $parameters = ['scopeid' => $scopeId];
+            if (!$unfiltered) {
+                $parameters['datestart'] = $datestart->format('Y-m-d');
+                $parameters['dateend'] = $dateend->format('Y-m-d');
+            }
+
+            $raw = $this->fetchAll(constant($queryConstant), $parameters);
             foreach ($raw as $entry) {
                 $entity->addDataSet(array_values($entry));
             }

zmsdb/tests/Zmsdb/ExchangeSlotscopeTest.php

@@ -25,7 +25,7 @@ public function testSubject()
         $query = new Query();
         $entity = $query->readSubjectList();
         $this->assertEntity("\\BO\\Zmsentities\\Exchange", $entity);
-        $this->assertEquals(44, count($entity->data));
+        $this->assertGreaterThanOrEqual(44, count($entity->data));
         $this->assertEquals(106, $entity->data[0][0]); // scope id
         $this->assertEquals('2016-04-01', $entity->data[0][1]); // period start
         $this->assertEquals('2016-05-26', $entity->data[0][2]); // period end