feat: require E.164 phone numbers in v1

phone numvers is now validated as E.164.

Author: bfabio

testdata/v1/invalid/landingURL_invalid.yml

@@ -82,15 +82,15 @@ maintenance:
     - name: Francesco Rossi
       email: "francesco.rossi@comune.reggioemilia.it"
       affiliation: Comune di Reggio Emilia
-      phone: +39 231 13215112
+      phone: +3923113215112
     - name: Dario Bianchi
       email: "dario.bianchi@fornitore.it"
       affiliation: Fornitore Privato S.P.A.
-      phone: +39 16 24231322
+      phone: +391624231322
     - name: Giancarlo Verdi
       email: "dario.bianchi@fornitore.it"
       affiliation: Fornitore Privato S.P.A.
-      phone: +39 16 24231322
+      phone: +391624231322
 
 localisation:
   localisationReady: true

testdata/v1/invalid/landingURL_wrong_type.yml

@@ -78,15 +78,15 @@ maintenance:
     - name: Francesco Rossi
       email: "francesco.rossi@comune.reggioemilia.it"
       affiliation: Comune di Reggio Emilia
-      phone: +39 231 13215112
+      phone: +3923113215112
     - name: Dario Bianchi
       email: "dario.bianchi@fornitore.it"
       affiliation: Fornitore Privato S.P.A.
-      phone: +39 16 24231322
+      phone: +391624231322
     - name: Giancarlo Verdi
       email: "dario.bianchi@fornitore.it"
       affiliation: Fornitore Privato S.P.A.
-      phone: +39 16 24231322
+      phone: +391624231322
 
 localisation:
   localisationReady: true

testdata/v1/invalid/maintenance_contacts_phone_invalid.yml

@@ -0,0 +1,36 @@
+publiccodeYmlVersion: "1"
+
+name: TestSoftware
+url: "https://github.com/italia/developers.italia.it.git"
+
+platforms:
+  - web
+
+developmentStatus: stable
+
+softwareType: "standalone/web"
+
+description:
+  en:
+    shortDescription: "A test software for v1 parsing."
+    longDescription: >
+      This is a long description for the test software used to verify
+      that the v1 parser works correctly. It needs to be at least 150
+      characters long to pass validation checks in the publiccode.yml
+      parser implementation. This is enough text now.
+    features:
+      - Test feature
+
+legal:
+  license: MIT
+
+maintenance:
+  type: internal
+  contacts:
+    - name: Test Contact
+      phone: "06 1234567"
+
+localisation:
+  localisationReady: true
+  availableLanguages:
+    - en

testdata/v1/invalid/no-network/landingURL_invalid.yml

@@ -82,15 +82,15 @@ maintenance:
     - name: Francesco Rossi
       email: "francesco.rossi@comune.reggioemilia.it"
       affiliation: Comune di Reggio Emilia
-      phone: +39 231 13215112
+      phone: +3923113215112
     - name: Dario Bianchi
       email: "dario.bianchi@fornitore.it"
       affiliation: Fornitore Privato S.P.A.
-      phone: +39 16 24231322
+      phone: +391624231322
     - name: Giancarlo Verdi
       email: "dario.bianchi@fornitore.it"
       affiliation: Fornitore Privato S.P.A.
-      phone: +39 16 24231322
+      phone: +391624231322
 
 localisation:
   localisationReady: true

v1.go

@@ -94,7 +94,7 @@ type ContactV1 struct {
 	Name        string  `json:"name"                  validate:"required"          yaml:"name"`
 	Email       *string `json:"email,omitempty"       validate:"omitempty,email"   yaml:"email,omitempty"`
 	Affiliation *string `json:"affiliation,omitempty" yaml:"affiliation,omitempty"`
-	Phone       *string `json:"phone,omitempty"       validate:"omitempty"         yaml:"phone,omitempty"`
+	Phone       *string `json:"phone,omitempty"       validate:"omitempty,e164"    yaml:"phone,omitempty"`
 }
 
 // DependencyV1 describes system-level dependencies required to install and use this software.

v1_test.go

@@ -250,6 +250,9 @@ func TestInvalidTestcasesV1(t *testing.T) {
 		"maintenance_contacts_email_invalid.yml": ValidationResults{
 			ValidationError{"maintenance.contacts[0].email", "email must be a valid email address", 49, 9},
 		},
+		"maintenance_contacts_phone_invalid.yml": ValidationResults{
+			ValidationError{"maintenance.contacts[0].phone", "phone must be a valid E.164 formatted phone number", 31, 7},
+		},
 		"maintenance_contacts_missing_with_type_community.yml": ValidationResults{
 			ValidationError{"maintenance.contacts", "contacts is a required field when \"type\" is \"community\"", 44, 3},
 		},