perf: compile BCP 47 language tag regex once at package init#341
Closed
creed-bratton wants to merge 1 commit intoitalia:mainfrom
Closed
perf: compile BCP 47 language tag regex once at package init#341creed-bratton wants to merge 1 commit intoitalia:mainfrom
creed-bratton wants to merge 1 commit intoitalia:mainfrom
Conversation
creed-bratton
force-pushed
the
bcp47-regex-precompile
branch
from
d5de403 to
47474cb
Compare
creed-bratton
added a commit
to creed-bratton/publiccode-parser-go
that referenced
this pull request
Apr 12, 2026
go-playground/validator@b599053 added bcp47_strict_language_tag as a built-in validator (go-playground/validator#1489), so our copy is now redundant. Drop validators/bcp47.go and its tests; update bcp47_keys to delegate to the built-in tag via a package-level Validate instance. Closes italia#341, closes italia#342.
Contributor
Author
|
Superseded by go-playground/validator#1489 (merged upstream). Will switch to the built-in validator in a new PR. |
creed-bratton
added a commit
to creed-bratton/publiccode-parser-go
that referenced
this pull request
Apr 15, 2026
go-playground/validator@b599053 added bcp47_strict_language_tag as a built-in validator (go-playground/validator#1489), so our copy is now redundant. Drop validators/bcp47.go and its tests; update bcp47_keys to delegate to the built-in tag via a package-level Validate instance. Closes italia#341, closes italia#342.
bfabio
pushed a commit
that referenced
this pull request
Apr 15, 2026
go-playground/validator@b599053 added bcp47_strict_language_tag as a built-in validator (go-playground/validator#1489), so our copy is now redundant. Drop validators/bcp47.go and its tests; update bcp47_keys to delegate to the built-in tag via a package-level Validate instance. Closes #341, closes #342.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isValidBCP47StrictLanguageTagwas callingregexp.MustCompileon a complex, constant pattern on every invocation. This function runs for every key in thedescriptionmap and every entry inavailableLanguages, so a single parse triggers 10-50+ compilations of the same regex.Move the regex to a package-level
varso it is compiled once at program startup.